[LU-15916] stock pages for debug buffer use are never filled Created: 06/Jun/22 Updated: 06/Jun/22 |
|
| Status: | Open |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.16.0, Lustre 2.12.9 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major |
| Reporter: | Oleg Drokin | Assignee: | WC Triage |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
Looks like all the logic around tcd_cur_stock_pages in a tcd structure is dead. The number is never increased since the function that did it - cfs_trace_refill_stock() was removed in commit 9dfbed6fa33dfcd69afa3383f20c3973215e8000 (https://review.whamcloud.com/38913) because it was never called anyway. As such the TCD_STOCK_PAGES define is dead and this bit in cfs_trace_get_tage_try() as well:
if (tcd->tcd_cur_stock_pages > 0) {
tage = cfs_tage_from_list(tcd->tcd_stock_pages.prev);
--tcd->tcd_cur_stock_pages;
list_del_init(&tage->linkage);
It's kinda strange we actually never populate this list from the "freed" pages and instead always free them to allocate anew as we need them. |