[LU-1604] md_ucred() shouldn't be called in osd-ldiskfs when running with OFD Created: 05/Jul/12  Updated: 27/Sep/12  Resolved: 27/Sep/12

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.3.0
Fix Version/s: Lustre 2.3.0

Type: Bug Priority: Minor
Reporter: Johann Lombardi (Inactive) Assignee: Johann Lombardi (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 4546

 Description   

md_ucred() is called in several places (in osd_push_ctxt() used by quota, but also in __osd_oi_insert()) in osd-ldiskfs. This code ends up calling a function in mdd and should thus not be executed when using OFD.

 Comments   
Comment by Johann Lombardi (Inactive) [ 05/Jul/12 ]

http://review.whamcloud.com/3286

Comment by Andreas Dilger [ 05/Jul/12 ]

It seems strange that there are two implementations of "osd_push_ctxt()" in osd-ldiskfs, both with different parameters and implementations. I'm really hoping this is something that will go away when we have moved the MDS stack entirely over to OSD API?

Comment by Johann Lombardi (Inactive) [ 05/Jul/12 ]

Indeed, that's weird.
Yes, all this will go away as soon as we move to the new MDS stack. We no longer need push/pop context in orion since quota enforcement is handled inside lquota.

Comment by Alex Zhuravlev [ 05/Jul/12 ]

I think osd should not be looking into this structure in general. all required information can be taken from objects/inodes ?

Comment by Johann Lombardi (Inactive) [ 13/Jul/12 ]

Patch landed.

Comment by Jodi Levi (Inactive) [ 27/Sep/12 ]

Reopening to add fix version 2.3

Generated at Sat Feb 10 01:18:06 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.