[#LU-16091] Set S_ENCRYPTED flag on OST objects for encrypted files

[LU-16091] Set S_ENCRYPTED flag on OST objects for encrypted files Created: 11/Aug/22 Updated: 20/May/23 Resolved: 13/Jan/23
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	Lustre 2.16.0
Fix Version/s:	Lustre 2.16.0, Lustre 2.15.3

Type:

Bug

Priority:

Minor

Reporter:

Sebastien Buisson

Assignee:

Sebastien Buisson

Resolution:

Fixed

Votes:

Labels:

encryption, patch, security

Issue Links:

Related
is related to	~~LU-12275~~	Client-side file data encryption	Resolved
is related to	~~LU-14677~~	lfs migrate/mirror of encrypted files	Resolved
is related to	~~LU-12275~~	Client-side file data encryption	Resolved

Severity:

Rank (Obsolete):

9223372036854775807

Description

On MDT side, the S_ENCRYPTED flag is set when setting the encryption context, because internally, ldiskfs sets the LDISKFS_ENCRYPT_FL flag on the on-disk inode when the encryption.c xattr is being set (along with the LUSTRE_ENCRYPT_FL flag in the LMA).

On OST side, the LUSTRE_ENCRYPT_FL flag in the LMA is also set. But this does not lead to the LDISKFS_ENCRYPT_FL flag being set on the on-disk inode.

So we would need to improve OSD layer’s behavior. By adding a dumb encryption context on OST objects when the LUSTRE_ENCRYPT_FL flag gets set in the LMA, ldiskfs would internally set the LDISKFS_ENCRYPT_FL flag on the on-disk inode.

Comments

Comment by Gerrit Updater [ 11/Aug/22 ]

"Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/48198
Subject: ~~LU-16091~~ enc: S_ENCRYPTED flag on OST objects for enc files
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4604662f7a9e83a8908922b0cf9f27b5bffc9e09

Comment by Gerrit Updater [ 19/Sep/22 ]

"Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/48587
Subject: ~~LU-16091~~ tests: exercise sanity-sec with patch
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8ca59d135b3c6c9bc5d292388c4aeb2db414b6fb

Comment by Gerrit Updater [ 19/Sep/22 ]

"Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/48589
Subject: ~~LU-16091~~ tests: exercise sanity-sec with patch 2
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fd4208cd7e16273a3c7bc067aecc990f12cfb0c4

Comment by Gerrit Updater [ 04/Oct/22 ]

"Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/48757
Subject: ~~LU-16091~~ tests: exercise sanity-sec with patch 3
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a851bb5ddc6755f870f0f10e954413aa3692b60d

Comment by Gerrit Updater [ 13/Jan/23 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/48198/
Subject: ~~LU-16091~~ enc: S_ENCRYPTED flag on OST objects for enc files
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 348446d6370b3f63f0da8a96997b3295f896c6fb

Comment by Peter Jones [ 13/Jan/23 ]

Landed for 2.16

Comment by Gerrit Updater [ 17/Apr/23 ]

"Sebastien Buisson <sbuisson@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50657
Subject: ~~LU-16091~~ enc: S_ENCRYPTED flag on OST objects for enc files
Project: fs/lustre-release
Branch: b2_15
Current Patch Set: 1
Commit: d6b2056585b53e525eba3046074c26b740ff329d