[LU-16167] lctl llog_print do not print all record Created: 19/Sep/22  Updated: 13/Nov/23  Resolved: 14/Nov/22

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.15.0, Lustre 2.15.1
Fix Version/s: Lustre 2.16.0, Lustre 2.15.4

Type: Bug Priority: Minor
Reporter: Etienne Aujames Assignee: Etienne Aujames
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-15142 LCTL: permanent parameter deletion an... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

If a lot of contiguous records are skipped (>64), llog_print will stop the processing and will not display the last records.

With the https://review.whamcloud.com/45332 ("LU-15142 lctl: fixes for set_param -P and llog_print"), the following code is not true anymore:

 int jt_llog_print_iter(char *logname, long start, long end,
...
                /* There is no "end of list" marker, record was not modified */
                if (strcmp(record, logname) == 0)                <------
                        break;

"record" could be unmodified if all processed records are skipped.

"llog_print -r" is not affected by this issue.

 Comments   
Comment by Gerrit Updater [ 19/Sep/22 ]

"Etienne AUJAMES <eaujames@ddn.com>" uploaded a new patch: https://review.whamcloud.com/48586
Subject: LU-16167 obdclass: fix lctl llog_print with skipped records
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8ef9877a6ec756d0ef1da5a8827d861cac63fd9d

Comment by Gerrit Updater [ 14/Nov/22 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/48586/
Subject: LU-16167 obdclass: fix lctl llog_print with skipped records
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c6da54aa7546440339265c644538d3d109e46bde

Comment by Peter Jones [ 14/Nov/22 ]

Landed for 2.16

Comment by Gerrit Updater [ 05/Jun/23 ]

"Etienne AUJAMES <eaujames@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51221
Subject: LU-16167 obdclass: fix lctl llog_print with skipped records
Project: fs/lustre-release
Branch: b2_15
Current Patch Set: 1
Commit: 9db96d00238d23b7bdbfd020919b87e636b7c532

Comment by Gerrit Updater [ 13/Nov/23 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/51221/
Subject: LU-16167 obdclass: fix lctl llog_print with skipped records
Project: fs/lustre-release
Branch: b2_15
Current Patch Set:
Commit: 73888fd0970dd6e45162b9244edd4573bfe7aae6

Generated at Sat Feb 10 03:24:36 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.