[LU-16230] git Change-ID hook is not supported on RHEL8

• Status: Open
• Project: Lustre
• Type: Bug
• Priority: Minor
• Reporter: James A Simmons
• Assignee: Jian Yu
• Resolution: Unresolved
• Severity: 3

Description

The latest git commit-msg hook being used by whamcloud is using git-interpert-trailer which is not present on RedHAT systems. On our RHLE8 testbed I see:

".git/COMMIT_EDITMSG" 2934L, 83071C written
unknown option: --trailer
usage: git [--version] [--help] [-C <path>] [-c <name>=<value>]
           [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
           [-p | --paginate | -P | --no-pager] [--no-replace-objects] [--bare]
           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
           <command> [<args>]
cannot insert change-id line in .git/COMMIT_EDITMSG

Comments

[James A Simmons]

Also contrib/git-hooks/commit-msg produces an empty ChangeID.

[Peter Jones]

Jian

Can you please advise on this one?

Thanks

Peter

[Andreas Dilger]

James, I just stumbled across this ticket looking for something else. I have been using the Lustre commit hook on RHEL8 without issues. Are you using the latest one from contrib/git-hooks/commit-msg? Normally I set this up as a symlink so that it is always the latest for a particular branch:

# cd .git/hooks
# ln -sf ../../contrib/git-hooks/commit-msg
# ln -sf ../../contrib/git-hooks/prepare-commit-msg

[James A Simmons]

The version of git we have installed is git version 1.8.3.1. Currently I use an old version of commit-msg that seems to work. Hm, this ticket is old so maybe that is not needed any more. I have to check.

Ah the system I'm using for push and pulls is a RHEL7 platform One of the  last at ORNL.

[Andreas Dilger]

I'm using contrib/git-hooks/commit-msg without problems on my el7.9 system as well (same Git version). It doesn't use or mention "trailer" at all, so maybe you are using some other commit-msg hook?