[#LU-163] compilebench fail on NFS v4 client

[LU-163] compilebench fail on NFS v4 client Created: 24/Mar/11 Updated: 14/Jun/11 Resolved: 14/Jun/11
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	Lustre 2.1.0
Fix Version/s:	Lustre 2.1.0, Lustre 1.8.6

Type:

Bug

Priority:

Minor

Reporter:

Sarah Liu

Assignee:

nasf (Inactive)

Resolution:

Fixed

Votes:

Labels:

None

Severity:

Rank (Obsolete):

4985

Description

running compilebench on 2 NFS v4 clients, failed. this test passed on NFS v3 clients and if I use non-lustre as NFS server, it can pass too. More information can find on Maloo.

test log
------------
./compilebench -D /mnt/lustre/d0.compilebench -i 2 -r 2 --makej
using working directory /mnt/lustre/d0.compilebench, 2 intial dirs 2 runs
native unpatched native-2 222MB in 224.40 seconds (0.99 MB/s)
Traceback (most recent call last):
File "./compilebench", line 567, in ?
dset = dataset(options.sources, rnd)
File "./compilebench", line 319, in _init_
self.unpatched = native_order(self.unpatched, "unpatched")
File "./compilebench", line 103, in native_order
rmrf(dirname)
File "./compilebench", line 68, in rmrf
os.rmdir(os.path.join(root, name))
OSError: [Errno 39] Directory not empty: '/mnt/lustre/d0.compilebench/native-2/ss
ound/oss'
parallel-scale test_compilebench: @@@@@@ FAIL: compilebench failed: 1

Comments

Comment by Peter Jones [ 25/Mar/11 ]

Lai will look into this one

Comment by Oleg Drokin [ 25/Mar/11 ]

A link to Maloo would be nice to have to

Comment by Sarah Liu [ 25/Mar/11 ]

Here is the Maloo link:
https://maloo.whamcloud.com/test_sets/6426b83a-56a4-11e0-bb3d-52540025f9af

Comment by Sarah Liu [ 28/Mar/11 ]

Besides compilebench, metabench and connectathon are also failed, not sure if they are caused by the same reason.

Comment by Lai Siyao [ 31/Mar/11 ]

I found the NFS4 on lustre can't readdir for more than 1 page, I can reproduce this issue with `ls` on a big directory. Looking into this, I found the hash value for dirent under a directory is not got in ascending order, which cause nfs4_decode_dirent() return -EBADCOOKIE.

Comment by Lai Siyao [ 14/Apr/11 ]

Linux nfsv4 implementation has below check for cookie (aka hash, or offset):

static __be32
nfsd4_readdir(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
              struct nfsd4_readdir *readdir)
{
        ...
        if ((cookie > ~(u32)0) || (cookie == 1) || (cookie == 2) ||
            (cookie == 0 && memcmp(readdir->rd_verf.data, zeroverf.data, NFS4_VERIFIER_SIZE)))
                return nfserr_bad_cookie;
        ...
}

If (cookie > ~(u32)0), it will return nfserr_bad_cookie, however lustre 2.x uses 64bit hash, so this check tend to fail.

I've checked NFSv4 IETF, the size of cookie is 64bit long, I think it's a bug in Linux nfsv4 implementation.

Comment by nasf (Inactive) [ 15/Apr/11 ]

The issue about nfs readdir cookie exists for a long time. Before bug 20581 (~~LU-71~~) patch landed, only 32-bit readdir hash is used, so nfs against lustre can work well. But now, for 64-bit readdir hash, nfs against Lustre cannot work. I cannot find perfect solution for that, except for some hack.

1) Introduce new client-side mount options "64bithash/no64bithash" or similar for the client to be as nfs server. Then "ll_readdir()" can return 32-bit hash/offset for nfs case. But under such case, all application on such client are affected by bug 20581.

2) Hack in "ll_fh_to_dentry()", to set some special flags on dentry, then "ll_readdir()" also can distinguish nfs case. Under such case, only nfs applications are affected by bug 20581.

Andreas, how do you think?

Comment by Andreas Dilger [ 15/Apr/11 ]

There is already a mount option for NFS to export only 32-bit inode numbers. It is documented in the bugzilla bug. I don't recall what it is called, but it should be easy to find.

Comment by nasf (Inactive) [ 16/Apr/11 ]

You mean "nfs.enable_ino64=0", right? I think it is nfs client-side parameter. We need more general nfs server side mount options to allow 32-bit application to run smoothly on 64-bit lustre client. Seems we have "32bitapi" mount options for that. I suggest to test nfs related cases with such option enabled.

Comment by Andreas Dilger [ 17/Apr/11 ]

The current implementation of "32bitapi" is not sufficient to make NFS servers work correctly. The problem, as discussed in bugzilla, is that the NFS kernel code has a function that is traversing a directory looking for (dirent->d_ino == inode->i_ino), but the dirent returned to NFS with "32bitapi" has a 32-bit inode number in it (as requested), but the inode internally has a 64-bit inode to avoid collision problems. My suggestion, before we changed to using nfs.enable_ino64=0, was to add a lustre-specific directory traversal that is comparing full 128-bit FID values instead of the inode numbers. I don't think the amount of effort is huge, but "enable_ino64" was even easier.

If you feel that we need an NFS server-side fix for this then I think we need to write our own directory iterator. Please see the details in bugzilla.

Comment by Lai Siyao [ 18/Apr/11 ]

Hi Sarah, could you set '32bitapi' in lustre client mount option, and run those failed test again?

Comment by Sarah Liu [ 18/Apr/11 ]

sure, will do it today.

Comment by Sarah Liu [ 18/Apr/11 ]

I ran compilebench with the additional option, still failed. sorry I cannot upload the result to Maloo, here is the suite log, if you need anything else, I will attach here.

lustre client:
--------------------------
[root@client-5-ib ~]# mount
/dev/sda2 on / type ext3 (rw)
proc on /proc type proc (rw)
sysfs on /sys type sysfs (rw)
devpts on /dev/pts type devpts (rw,gid=5,mode=620)
/dev/sda1 on /boot type ext3 (rw)
tmpfs on /dev/shm type tmpfs (rw)
none on /proc/sys/fs/binfmt_misc type binfmt_misc (rw)
sunrpc on /var/lib/nfs/rpc_pipefs type rpc_pipefs (rw)
192.168.4.128@o2ib:/lustre on /mnt/lustre type lustre (rw,flock,32bitapi)
nfsd on /proc/fs/nfsd type nfsd (rw)

error log:
-----------------------------
== parallel-scale test compilebench: compilebench ===============================
====================== 21:09:51 (1303099791)
OPTIONS:
cbench_DIR=/usr/bin
cbench_IDIRS=2
cbench_RUNS=2
./compilebench -D /mnt/lustre/d0.compilebench -i 2 -r 2 --makej
using working directory /mnt/lustre/d0.compilebench, 2 intial dirs 2 runs
Traceback (most recent call last):
File "./compilebench", line 567, in ?
dset = dataset(options.sources, rnd)
File "./compilebench", line 319, in _init_
self.unpatched = native_order(self.unpatched, "unpatched")
File "./compilebench", line 97, in native_order
run_directory(tmplist, dirname, "native %s" % tag)
File "./compilebench", line 225, in run_directory
fp = file(fname, 'a+')
IOError: [Errno 2] No such file or directory: '/mnt/lustre/d0.compilebench/nativv
e-2/COPYING'
parallel-scale test_compilebench: @@@@@@ FAIL: compilebench failed: 1

Comment by nasf (Inactive) [ 19/Apr/11 ]

You can verify with this patch (2.x based):
http://review.whamcloud.com/#change,432

And also please mount Lustre client with "-o 32bitapi" which is to be as NFS server. If you want to verify "1.8 client + 2.x server", then also need the client-side patch:
http://review.whamcloud.com/#change,410

Comment by Sarah Liu [ 20/Apr/11 ]

I tested with the above patch with 2.1 server and clients, failed again. client-5 is the lustre client and NFS server, client-18/22 are nfs clients.

[root@client-5 ~]# mount |grep lustre
192.168.4.128@o2ib:/lustre on /mnt/lustre type lustre (rw,flock,32bitapi)

[root@client-18 tests]# mount|grep lustre
192.168.4.5:/ on /mnt/lustre type nfs4 (rw,addr=192.168.4.5)

Here is the result link:
https://maloo.whamcloud.com/test_sets/1bb54574-6baa-11e0-b32b-52540025f9af

Comment by nasf (Inactive) [ 22/Apr/11 ]

A new patch for that maybe helpful.
http://review.whamcloud.com/#change,432 (set 4)

Comment by nasf (Inactive) [ 22/Apr/11 ]

This is test result with above patch:
Lustre client mount with "-o 32bitapi"

https://maloo.whamcloud.com/test_sets/3ff06102-6d13-11e0-b32b-52540025f9af

Comment by Sarah Liu [ 26/Apr/11 ]

Fan Yong,
I verified with your patch, the compilebench can pass the test but the connectathon failed on NFS4. I also ran connectathon on NFS3 and local fs(without lustre), all pass. Could you please check this? Here is the result link
https://maloo.whamcloud.com/test_sets/98c11742-7054-11e0-a1b3-52540025f9af

Comment by nasf (Inactive) [ 27/Apr/11 ]

Have you used "-o 32bitapi" on lustre client which is as the nfs4 server?
I have tested with "-o 32bitapi", and connectathon can pass against nfs4. Unfortunately, I cannot upload the test result

Comment by Sarah Liu [ 27/Apr/11 ]

it's weird, I tried again, failed again. client-5 as lustre client and nfs server, client-18/22 as nfs clients

[root@client-5 ~]# mount|grep lustre
192.168.4.128@o2ib:/lustre on /mnt/lustre type lustre (rw,flock,32bitapi)

[root@client-18 105557]# mount|grep nfs
sunrpc on /var/lib/nfs/rpc_pipefs type rpc_pipefs (rw)
10.10.4.5:/ on /mnt/lustre type nfs4 (rw,addr=10.10.4.5)

https://maloo.whamcloud.com/test_sets/8d18aed2-70f9-11e0-a1b3-52540025f9af

Comment by Sarah Liu [ 28/Apr/11 ]

here is the result of connectathon on NFS4 without patch
https://maloo.whamcloud.com/test_sets/5e45d016-721c-11e0-a1b3-52540025f9af

Comment by nasf (Inactive) [ 02/May/11 ]

This is my test:
https://maloo.whamcloud.com/test_sets/4e9b1592-7490-11e0-a1b3-52540025f9af

mds & oss: client-12

Lustre client: client-13
192.168.4.12@o2ib:/lustre on /mnt/lustre type lustre (rw,32bitapi,flock)
nfs exports: /mnt/lustre 10.10.4.1(rw,no_root_squash,fsid=0)

NFS client: client-1
10.10.4.13:/ on /mnt/lustre type nfs4 (rw,addr=10.10.4.13)

sh auster -f sarah-nfs-nfs-client parallel-scale --only connectathon
Are there any different parameters in your test?

Comment by Sarah Liu [ 02/May/11 ]

Ah, I found the difference. I use all_squash in my exports file, it might be a lustre bug, I am not sure if it's NFS4's problem. I ran the failed command ./excltest under /mnt/lustre/d0.connectathon, got weird permission file

-rwxr-xr-x 1 sanityusr sanityusr 7997 May 2 13:13 excltest
---------- 1 sanityusr sanityusr 0 Feb 13 1970 exctest.file

my /etc/exports:
/mnt/lustre *(fsid=0,rw,all_squash,anonuid=500,anongid=500)

Comment by nasf (Inactive) [ 03/May/11 ]

You found a new bug! It is related with open permission check, but not related with 64/32-bit dir hash. Please open a new ticket and assign to me. Thanks!

Comment by Sarah Liu [ 05/May/11 ]

Hi Fan Yong,

I ran ior on NFS3 with your patch, got an issue.
https://maloo.whamcloud.com/test_sets/ba7f8ce4-76e7-11e0-9b1b-52540025f9af

After some initial analyse, it seems if you create a file under a striped dir on nfs client, it did not get the stripe pattern from the parent. It is probably this patch has some problems. please check.

Btw on NFS4, it works.

client-18 is nfs3 client, client-5 is lustre client.

root@client-18 tests]# touch /mnt/lustre/d0.ior/test
[root@client-18 tests]# ssh client-5
Last login: Thu May 5 00:15:31 2011 from client-18.lab.whamcloud.com
[root@client-5 ~]# lfs getstripe /mnt/lustre/d0.ior/
/mnt/lustre/d0.ior/
stripe_count: -1 stripe_size: 0 stripe_offset: -1
/mnt/lustre/d0.ior//c has no stripe info
/mnt/lustre/d0.ior//b has no stripe info
/mnt/lustre/d0.ior//test has no stripe info

Run ior test on a non-patched build, got the same failure. Create a new ticket to track. ~~LU-307~~

Comment by nasf (Inactive) [ 11/May/11 ]

I will investigate ~~LU-307~~, and add you as watcher.

Comment by nasf (Inactive) [ 16/May/11 ]

The patch for ~~LU-163~~ to be inspected:

http://review.whamcloud.com/#change,432

Comment by nasf (Inactive) [ 20/May/11 ]

I have tested above patch on Toro, no new issues were introduced. Unfortunately, I cannot upload the test results to Maloo

Comment by Sarah Liu [ 24/May/11 ]

verified on NFS4, here is the result
https://maloo.whamcloud.com/test_sets/cddc968e-863b-11e0-b4df-52540025f9af

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

lustre/utils/wiretest.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch
lustre/include/dt_object.h
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series
lustre/lclient/lcommon_cl.c
lustre/mdd/mdd_dir.c
lustre/include/linux/lustre_compat25.h
lustre/include/lustre/lustre_idl.h
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
lustre/include/lclient.h
lustre/mdd/mdd_object.c
lustre/mdd/mdd_orphans.c
lustre/osd-ldiskfs/osd_handler.c
lustre/llite/file.c
lustre/obdclass/obd_mount.c
lustre/mdt/mdt_handler.c
lustre/ptlrpc/wiretest.c
lustre/llite/llite_internal.h
lustre/llite/llite_nfs.c
lustre/llite/namei.c
lustre/llite/dcache.c
lustre/utils/wirecheck.c
lustre/llite/llite_lib.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
lustre/obdclass/lprocfs_status.c
lustre/llite/dir.c
lustre/liblustre/dir.c

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

lustre/mdd/mdd_object.c
lustre/mdt/mdt_handler.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
lustre/llite/llite_internal.h
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series
lustre/llite/dir.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
lustre/llite/namei.c
lustre/mdd/mdd_orphans.c
lustre/lclient/lcommon_cl.c
lustre/obdclass/lprocfs_status.c
lustre/llite/file.c
ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
lustre/llite/llite_lib.c
lustre/llite/llite_nfs.c
lustre/liblustre/dir.c
lustre/include/dt_object.h
lustre/utils/wiretest.c
lustre/obdclass/obd_mount.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch
lustre/ptlrpc/wiretest.c
lustre/utils/wirecheck.c
lustre/include/lustre/lustre_idl.h
lustre/llite/dcache.c
lustre/mdd/mdd_dir.c
lustre/include/linux/lustre_compat25.h
lustre/include/lclient.h
lustre/osd-ldiskfs/osd_handler.c

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

lustre/mdt/mdt_handler.c
lustre/llite/llite_nfs.c
lustre/lclient/lcommon_cl.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
lustre/obdclass/lprocfs_status.c
ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
lustre/ptlrpc/wiretest.c
lustre/utils/wirecheck.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series
lustre/llite/namei.c
lustre/include/lclient.h
lustre/include/dt_object.h
lustre/llite/llite_lib.c
lustre/mdd/mdd_orphans.c
lustre/liblustre/dir.c
lustre/osd-ldiskfs/osd_handler.c
lustre/llite/dcache.c
lustre/include/linux/lustre_compat25.h
lustre/include/lustre/lustre_idl.h
lustre/llite/llite_internal.h
lustre/mdd/mdd_dir.c
lustre/obdclass/obd_mount.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch
lustre/utils/wiretest.c
lustre/llite/file.c
lustre/mdd/mdd_object.c
lustre/llite/dir.c

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » i686,client,el5,inkernel #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series
lustre/mdd/mdd_orphans.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
lustre/include/lustre/lustre_idl.h
lustre/include/lclient.h
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
lustre/liblustre/dir.c
lustre/obdclass/lprocfs_status.c
lustre/mdd/mdd_object.c
lustre/llite/dir.c
lustre/include/dt_object.h
lustre/llite/file.c
lustre/llite/llite_nfs.c
lustre/utils/wirecheck.c
lustre/llite/llite_internal.h
lustre/llite/namei.c
lustre/mdd/mdd_dir.c
lustre/mdt/mdt_handler.c
lustre/lclient/lcommon_cl.c
lustre/include/linux/lustre_compat25.h
lustre/llite/dcache.c
lustre/osd-ldiskfs/osd_handler.c
lustre/ptlrpc/wiretest.c
lustre/llite/llite_lib.c
lustre/utils/wiretest.c
lustre/obdclass/obd_mount.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

lustre/include/dt_object.h
lustre/liblustre/dir.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
lustre/mdd/mdd_object.c
lustre/mdd/mdd_dir.c
lustre/include/linux/lustre_compat25.h
lustre/llite/llite_nfs.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series
lustre/lclient/lcommon_cl.c
lustre/obdclass/lprocfs_status.c
lustre/include/lustre/lustre_idl.h
ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
lustre/utils/wiretest.c
lustre/llite/llite_lib.c
lustre/llite/namei.c
lustre/llite/dcache.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch
lustre/mdt/mdt_handler.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
lustre/llite/llite_internal.h
lustre/llite/file.c
lustre/osd-ldiskfs/osd_handler.c
lustre/ptlrpc/wiretest.c
lustre/llite/dir.c
lustre/include/lclient.h
lustre/utils/wirecheck.c
lustre/obdclass/obd_mount.c
lustre/mdd/mdd_orphans.c

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » i686,client,el6,inkernel #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

lustre/mdd/mdd_dir.c
lustre/mdd/mdd_orphans.c
lustre/llite/llite_lib.c
lustre/llite/dir.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
lustre/mdt/mdt_handler.c
lustre/llite/file.c
lustre/include/lustre/lustre_idl.h
lustre/lclient/lcommon_cl.c
lustre/utils/wiretest.c
lustre/osd-ldiskfs/osd_handler.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch
lustre/obdclass/lprocfs_status.c
lustre/liblustre/dir.c
lustre/obdclass/obd_mount.c
lustre/mdd/mdd_object.c
ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
lustre/llite/dcache.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
lustre/llite/llite_nfs.c
lustre/include/lclient.h
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series
lustre/utils/wirecheck.c
lustre/ptlrpc/wiretest.c
lustre/include/linux/lustre_compat25.h
lustre/llite/llite_internal.h
lustre/llite/namei.c
lustre/include/dt_object.h

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » i686,client,el5,ofa #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

lustre/include/lustre/lustre_idl.h
lustre/include/dt_object.h
lustre/llite/dcache.c
lustre/llite/llite_internal.h
lustre/include/lclient.h
lustre/utils/wirecheck.c
lustre/llite/namei.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch
lustre/llite/llite_lib.c
lustre/mdd/mdd_dir.c
lustre/obdclass/obd_mount.c
lustre/mdt/mdt_handler.c
lustre/llite/llite_nfs.c
lustre/llite/file.c
lustre/ptlrpc/wiretest.c
lustre/utils/wiretest.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series
lustre/mdd/mdd_object.c
lustre/mdd/mdd_orphans.c
lustre/liblustre/dir.c
lustre/obdclass/lprocfs_status.c
lustre/lclient/lcommon_cl.c
lustre/osd-ldiskfs/osd_handler.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
lustre/include/linux/lustre_compat25.h
lustre/llite/dir.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

lustre/include/lustre/lustre_idl.h
lustre/liblustre/dir.c
lustre/mdt/mdt_handler.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch
lustre/llite/llite_lib.c
lustre/utils/wirecheck.c
lustre/include/dt_object.h
lustre/llite/llite_nfs.c
lustre/osd-ldiskfs/osd_handler.c
lustre/lclient/lcommon_cl.c
lustre/llite/dir.c
lustre/llite/dcache.c
lustre/utils/wiretest.c
lustre/mdd/mdd_object.c
lustre/llite/namei.c
lustre/llite/llite_internal.h
lustre/include/linux/lustre_compat25.h
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
lustre/ptlrpc/wiretest.c
lustre/obdclass/lprocfs_status.c
lustre/mdd/mdd_orphans.c
lustre/obdclass/obd_mount.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series
lustre/include/lclient.h
lustre/mdd/mdd_dir.c
ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
lustre/llite/file.c

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
lustre/llite/dir.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
lustre/include/linux/lustre_compat25.h
lustre/include/dt_object.h
lustre/utils/wiretest.c
lustre/llite/dcache.c
lustre/llite/file.c
lustre/osd-ldiskfs/osd_handler.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
lustre/include/lclient.h
lustre/include/lustre/lustre_idl.h
lustre/llite/llite_internal.h
lustre/llite/namei.c
lustre/mdd/mdd_object.c
lustre/ptlrpc/wiretest.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch
lustre/mdt/mdt_handler.c
lustre/llite/llite_nfs.c
lustre/mdd/mdd_dir.c
lustre/obdclass/lprocfs_status.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series
lustre/utils/wirecheck.c
lustre/liblustre/dir.c
lustre/llite/llite_lib.c
lustre/lclient/lcommon_cl.c
lustre/mdd/mdd_orphans.c
lustre/obdclass/obd_mount.c

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,ofa #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

lustre/mdt/mdt_handler.c
lustre/utils/wiretest.c
lustre/utils/wirecheck.c
lustre/llite/namei.c
lustre/llite/dcache.c
lustre/include/linux/lustre_compat25.h
lustre/lclient/lcommon_cl.c
lustre/llite/llite_lib.c
lustre/include/dt_object.h
lustre/mdd/mdd_dir.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
lustre/llite/dir.c
lustre/include/lustre/lustre_idl.h
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series
lustre/osd-ldiskfs/osd_handler.c
lustre/mdd/mdd_object.c
lustre/llite/llite_internal.h
lustre/mdd/mdd_orphans.c
ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
lustre/llite/llite_nfs.c
lustre/llite/file.c
lustre/ptlrpc/wiretest.c
lustre/obdclass/obd_mount.c
lustre/include/lclient.h
lustre/liblustre/dir.c
lustre/obdclass/lprocfs_status.c

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » i686,server,el5,inkernel #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

lustre/llite/dir.c
lustre/include/lustre/lustre_idl.h
lustre/llite/llite_internal.h
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
lustre/llite/namei.c
lustre/mdd/mdd_orphans.c
lustre/osd-ldiskfs/osd_handler.c
lustre/llite/llite_nfs.c
lustre/ptlrpc/wiretest.c
lustre/include/linux/lustre_compat25.h
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
lustre/mdd/mdd_object.c
lustre/obdclass/lprocfs_status.c
lustre/mdd/mdd_dir.c
lustre/utils/wiretest.c
lustre/mdt/mdt_handler.c
lustre/llite/file.c
lustre/utils/wirecheck.c
lustre/liblustre/dir.c
lustre/include/lclient.h
lustre/lclient/lcommon_cl.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series
lustre/llite/llite_lib.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch
lustre/include/dt_object.h
ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
lustre/obdclass/obd_mount.c
lustre/llite/dcache.c

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » i686,server,el6,inkernel #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

lustre/include/lclient.h
lustre/llite/dir.c
lustre/mdd/mdd_dir.c
lustre/llite/llite_internal.h
lustre/lclient/lcommon_cl.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
lustre/liblustre/dir.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
lustre/utils/wiretest.c
lustre/mdd/mdd_orphans.c
lustre/llite/namei.c
lustre/obdclass/lprocfs_status.c
lustre/include/dt_object.h
lustre/ptlrpc/wiretest.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series
lustre/osd-ldiskfs/osd_handler.c
lustre/llite/dcache.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch
ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
lustre/llite/file.c
lustre/obdclass/obd_mount.c
lustre/utils/wirecheck.c
lustre/include/lustre/lustre_idl.h
lustre/llite/llite_lib.c
lustre/llite/llite_nfs.c
lustre/mdd/mdd_object.c
lustre/include/linux/lustre_compat25.h
lustre/mdt/mdt_handler.c

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » x86_64,client,el5,ofa #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch
lustre/mdt/mdt_handler.c
lustre/llite/llite_internal.h
lustre/llite/llite_lib.c
lustre/liblustre/dir.c
lustre/utils/wirecheck.c
lustre/include/linux/lustre_compat25.h
lustre/obdclass/lprocfs_status.c
lustre/mdd/mdd_orphans.c
lustre/include/dt_object.h
lustre/llite/file.c
lustre/llite/dir.c
lustre/mdd/mdd_object.c
lustre/utils/wiretest.c
lustre/obdclass/obd_mount.c
lustre/lclient/lcommon_cl.c
lustre/llite/llite_nfs.c
lustre/ptlrpc/wiretest.c
lustre/include/lustre/lustre_idl.h
lustre/llite/dcache.c
lustre/include/lclient.h
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
lustre/mdd/mdd_dir.c
lustre/osd-ldiskfs/osd_handler.c
lustre/llite/namei.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » i686,server,el5,ofa #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
lustre/mdd/mdd_object.c
lustre/mdt/mdt_handler.c
lustre/obdclass/lprocfs_status.c
lustre/liblustre/dir.c
lustre/llite/llite_lib.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
lustre/ptlrpc/wiretest.c
lustre/lclient/lcommon_cl.c
lustre/include/lclient.h
lustre/utils/wirecheck.c
lustre/llite/file.c
lustre/llite/dcache.c
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch
lustre/llite/llite_nfs.c
lustre/mdd/mdd_dir.c
lustre/obdclass/obd_mount.c
lustre/utils/wiretest.c
lustre/llite/dir.c
lustre/osd-ldiskfs/osd_handler.c
lustre/llite/llite_internal.h
lustre/include/linux/lustre_compat25.h
lustre/include/lustre/lustre_idl.h
lustre/include/dt_object.h
ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
lustre/mdd/mdd_orphans.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series
lustre/llite/namei.c

Comment by Build Master (Inactive) [ 27/May/11 ]

Integrated in lustre-master » x86_64,server,el5,ofa #141
~~LU-163~~ MDS returns 32/64-bit dir name hash according to client type

Oleg Drokin : 96a5daa0c08d7b42ec368080a2a7f0dfb110ef98
Files :

lustre/llite/llite_lib.c
lustre/llite/namei.c
lustre/mdd/mdd_dir.c
lustre/include/lustre/lustre_idl.h
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash-rhel6.patch
lustre/llite/file.c
lustre/lclient/lcommon_cl.c
lustre/mdd/mdd_orphans.c
lustre/ptlrpc/wiretest.c
lustre/utils/wirecheck.c
lustre/llite/llite_internal.h
lustre/llite/llite_nfs.c
lustre/llite/dcache.c
lustre/liblustre/dir.c
lustre/obdclass/obd_mount.c
lustre/utils/wiretest.c
ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
lustre/include/dt_object.h
lustre/mdd/mdd_object.c
lustre/obdclass/lprocfs_status.c
lustre/osd-ldiskfs/osd_handler.c
ldiskfs/kernel_patches/patches/ext3-export-64bit-name-hash.patch
ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel6.series
lustre/llite/dir.c
lustre/include/lclient.h
lustre/include/linux/lustre_compat25.h
ldiskfs/kernel_patches/patches/ext4-export-64bit-name-hash.patch
lustre/mdt/mdt_handler.c

Comment by nasf (Inactive) [ 29/May/11 ]

The patch has been landed to Lustre-2.1 candidate, which includes the following fixes:

1) Use "OBD_CONNECT_64BITHASH" flag when connect to indicate whether the client support 64-bit dir name hash or not. liblustre client, 1.8.5 or older client do not support 64-bit dir name hash.
2) Register Lustre version 'get_name()' for NFS processing.
3) 'll_dir_seek()' processes name hash-based dir seek operation.
4) Re-define "DIR_END_OFF" as "0x7fffffffffffffffULL" to always return positive
dir name hash for successful seek.
5) Small cleanup for 'll_dops_init()' to drop unnecessary statahead process.

Comment by Sarah Liu [ 31/May/11 ]

verified and passed on RHEL5/NFSv4, but got this error on RHEL6/NFSv3 and NFSv4, not sure if it's the same as ~~LU-355~~
https://maloo.whamcloud.com/test_sets/9aed4c34-8bf7-11e0-aab9-52540025f9af

Comment by Peter Jones [ 06/Jun/11 ]

Reopening while remaining work completed

Patch http://review.whamcloud.com/#change,892

Comment by Peter Jones [ 06/Jun/11 ]

dropping priority as residual issues are not a blocker

Comment by Build Master (Inactive) [ 09/Jun/11 ]

Integrated in lustre-master » x86_64,client,el5,ofa #160
~~LU-163~~ Input valid 'mnt' parameter for 'dentry_open()'

Oleg Drokin : 76ced1d13cc921bd061a2726bab53211c69e1f52
Files :

lustre/include/lustre_disk.h
lustre/llite/llite_lib.c
lustre/obdclass/obd_mount.c
lustre/llite/llite_nfs.c
lustre/llite/llite_internal.h

Comment by Build Master (Inactive) [ 09/Jun/11 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #160
~~LU-163~~ Input valid 'mnt' parameter for 'dentry_open()'

Oleg Drokin : 76ced1d13cc921bd061a2726bab53211c69e1f52
Files :

lustre/obdclass/obd_mount.c
lustre/include/lustre_disk.h
lustre/llite/llite_lib.c
lustre/llite/llite_internal.h
lustre/llite/llite_nfs.c

Comment by Build Master (Inactive) [ 09/Jun/11 ]

Integrated in lustre-master » i686,client,el5,ofa #160
~~LU-163~~ Input valid 'mnt' parameter for 'dentry_open()'

Oleg Drokin : 76ced1d13cc921bd061a2726bab53211c69e1f52
Files :

lustre/llite/llite_lib.c
lustre/llite/llite_internal.h
lustre/llite/llite_nfs.c
lustre/obdclass/obd_mount.c
lustre/include/lustre_disk.h

Comment by Build Master (Inactive) [ 09/Jun/11 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #160
~~LU-163~~ Input valid 'mnt' parameter for 'dentry_open()'

Oleg Drokin : 76ced1d13cc921bd061a2726bab53211c69e1f52
Files :

lustre/obdclass/obd_mount.c
lustre/llite/llite_lib.c
lustre/llite/llite_internal.h
lustre/llite/llite_nfs.c
lustre/include/lustre_disk.h

Comment by Build Master (Inactive) [ 09/Jun/11 ]

Integrated in lustre-master » i686,client,el5,inkernel #160
~~LU-163~~ Input valid 'mnt' parameter for 'dentry_open()'

Oleg Drokin : 76ced1d13cc921bd061a2726bab53211c69e1f52
Files :

lustre/include/lustre_disk.h
lustre/llite/llite_nfs.c
lustre/obdclass/obd_mount.c
lustre/llite/llite_lib.c
lustre/llite/llite_internal.h

Comment by Build Master (Inactive) [ 09/Jun/11 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #160
~~LU-163~~ Input valid 'mnt' parameter for 'dentry_open()'

Oleg Drokin : 76ced1d13cc921bd061a2726bab53211c69e1f52
Files :

lustre/llite/llite_lib.c
lustre/include/lustre_disk.h
lustre/obdclass/obd_mount.c
lustre/llite/llite_nfs.c
lustre/llite/llite_internal.h

Comment by Build Master (Inactive) [ 09/Jun/11 ]

Integrated in lustre-master » x86_64,server,el5,ofa #160
~~LU-163~~ Input valid 'mnt' parameter for 'dentry_open()'

Oleg Drokin : 76ced1d13cc921bd061a2726bab53211c69e1f52
Files :

lustre/llite/llite_lib.c
lustre/include/lustre_disk.h
lustre/llite/llite_nfs.c
lustre/llite/llite_internal.h
lustre/obdclass/obd_mount.c

Comment by Build Master (Inactive) [ 09/Jun/11 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,ofa #160
~~LU-163~~ Input valid 'mnt' parameter for 'dentry_open()'

Oleg Drokin : 76ced1d13cc921bd061a2726bab53211c69e1f52
Files :

lustre/llite/llite_nfs.c
lustre/include/lustre_disk.h
lustre/llite/llite_lib.c
lustre/llite/llite_internal.h
lustre/obdclass/obd_mount.c

Comment by Build Master (Inactive) [ 09/Jun/11 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #160
~~LU-163~~ Input valid 'mnt' parameter for 'dentry_open()'

Oleg Drokin : 76ced1d13cc921bd061a2726bab53211c69e1f52
Files :

lustre/obdclass/obd_mount.c
lustre/llite/llite_internal.h
lustre/llite/llite_lib.c
lustre/include/lustre_disk.h
lustre/llite/llite_nfs.c

Comment by Build Master (Inactive) [ 09/Jun/11 ]

Integrated in lustre-master » i686,server,el5,ofa #160
~~LU-163~~ Input valid 'mnt' parameter for 'dentry_open()'

Oleg Drokin : 76ced1d13cc921bd061a2726bab53211c69e1f52
Files :

lustre/obdclass/obd_mount.c
lustre/llite/llite_nfs.c
lustre/llite/llite_lib.c
lustre/llite/llite_internal.h
lustre/include/lustre_disk.h

Comment by Build Master (Inactive) [ 09/Jun/11 ]

Integrated in lustre-master » i686,server,el5,inkernel #160
~~LU-163~~ Input valid 'mnt' parameter for 'dentry_open()'

Oleg Drokin : 76ced1d13cc921bd061a2726bab53211c69e1f52
Files :

lustre/llite/llite_lib.c
lustre/llite/llite_nfs.c
lustre/include/lustre_disk.h
lustre/obdclass/obd_mount.c
lustre/llite/llite_internal.h

Comment by Build Master (Inactive) [ 09/Jun/11 ]

Integrated in lustre-master » i686,client,el6,inkernel #160
~~LU-163~~ Input valid 'mnt' parameter for 'dentry_open()'

Oleg Drokin : 76ced1d13cc921bd061a2726bab53211c69e1f52
Files :

lustre/llite/llite_nfs.c
lustre/llite/llite_lib.c
lustre/llite/llite_internal.h
lustre/include/lustre_disk.h
lustre/obdclass/obd_mount.c

Comment by Build Master (Inactive) [ 09/Jun/11 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #160
~~LU-163~~ Input valid 'mnt' parameter for 'dentry_open()'

Oleg Drokin : 76ced1d13cc921bd061a2726bab53211c69e1f52
Files :

lustre/obdclass/obd_mount.c
lustre/llite/llite_internal.h
lustre/include/lustre_disk.h
lustre/llite/llite_nfs.c
lustre/llite/llite_lib.c

Comment by Build Master (Inactive) [ 09/Jun/11 ]

Integrated in lustre-master » i686,server,el6,inkernel #160
~~LU-163~~ Input valid 'mnt' parameter for 'dentry_open()'

Oleg Drokin : 76ced1d13cc921bd061a2726bab53211c69e1f52
Files :

lustre/include/lustre_disk.h
lustre/llite/llite_internal.h
lustre/obdclass/obd_mount.c
lustre/llite/llite_lib.c
lustre/llite/llite_nfs.c