[LU-16382] Make lustre.spec more compliant with SUSE OBS requirements Created: 12/Dec/22 Updated: 30/Nov/23 Resolved: 22/Apr/23 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.16.0 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Neil Brown | Assignee: | Neil Brown |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
The "Open Build Service" runs an "rpmlint" tool after building a package. This highlights various potential problems. Many of the problems it find with lustre.spec are worth fixing. Some examples: License "GPL" is not specific. It should be GPL-2.0 Summary: lines should be short, start with CAPs, end with period, and not repeat the name of the package Description should not be too short, and shouldn't just repeat summary Directories should not be implicitly created. Before adding a file in a new directory we should explicitly list the directory udev rules install by a package manager should go in %{_udevrulesdir}, not /etc/udev/rules.d. The later is for local sysadmin to use. A "%changelog" should always appear at the end, even if empty. SUSE prefers different "Group" names to Redhat, and Redhat has now deprecated Group: completely. Probably best to remove all group tags. Various other problems were found while trying to build lustre in the OBS, such as lustre-tests not declaring dependencies on various tools that it does in fact depend on - such as ping and bc.
|
| Comments |
| Comment by Gerrit Updater [ 12/Dec/22 ] |
|
"Neil Brown <neilb@suse.de>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49363 |
| Comment by Gerrit Updater [ 12/Dec/22 ] |
|
"Neil Brown <neilb@suse.de>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49364 |
| Comment by Gerrit Updater [ 12/Dec/22 ] |
|
"Neil Brown <neilb@suse.de>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49365 |
| Comment by Gerrit Updater [ 12/Dec/22 ] |
|
"Neil Brown <neilb@suse.de>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49366 |
| Comment by Gerrit Updater [ 12/Dec/22 ] |
|
"Neil Brown <neilb@suse.de>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49367 |
| Comment by Gerrit Updater [ 12/Dec/22 ] |
|
"Neil Brown <neilb@suse.de>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49368 |
| Comment by Gerrit Updater [ 12/Dec/22 ] |
|
"Neil Brown <neilb@suse.de>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49369 |
| Comment by Gerrit Updater [ 12/Dec/22 ] |
|
"Neil Brown <neilb@suse.de>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49370 |
| Comment by Gerrit Updater [ 12/Dec/22 ] |
|
"Neil Brown <neilb@suse.de>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49371 |
| Comment by Gerrit Updater [ 13/Dec/22 ] |
|
"Neil Brown <neilb@suse.de>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49382 |
| Comment by Gerrit Updater [ 13/Jan/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49382/ |
| Comment by Gerrit Updater [ 03/Feb/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49363/ |
| Comment by Gerrit Updater [ 14/Feb/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49364/ |
| Comment by Gerrit Updater [ 14/Feb/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49366/ |
| Comment by Gerrit Updater [ 23/Feb/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49367/ |
| Comment by Gerrit Updater [ 28/Mar/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49369/ |
| Comment by Gerrit Updater [ 11/Apr/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49368/ |
| Comment by Gerrit Updater [ 11/Apr/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49370/ |
| Comment by Gerrit Updater [ 11/Apr/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49371/ |
| Comment by Gerrit Updater [ 22/Apr/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49365/ |
| Comment by Peter Jones [ 22/Apr/23 ] |
|
Landed for 2.16 |
| Comment by Gerrit Updater [ 30/Nov/23 ] |
|
"Olaf Faaland <faaland1@llnl.gov>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/53299 |