[LU-16413] T10PI is broken for CentOS 8.x Created: 19/Dec/22  Updated: 19/Apr/23  Resolved: 07/Jan/23

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.16.0, Lustre 2.15.3

Type: Bug Priority: Minor
Reporter: Dongyang Li Assignee: Dongyang Li
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-16138 remove need for T10-PI block integrit... Reopened
is related to LU-16690 kernel: obd_memory max: 1854996506, o... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

The T10PI block integrity patches for lustre server kernel is broken, the bio_integrity_prep_fn interface is removed.

As a result the autoconf feature test macro HAVE_BIO_INTEGRITY_PREP_FN was not defined, and the custom block integrity generate/verify was never enabled for CentOS 8.x

The current block integrity generate/verify functions also require changes to be able to work on CentOS 8.x kernels.



 Comments   
Comment by Gerrit Updater [ 19/Dec/22 ]

"Li Dongyang <dongyangli@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49441
Subject: LU-16413 osd-ldiskfs: fix T10PI for CentOS8.x
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 74fa685da0d806a9fd47f837af22b27f8f37c800

Comment by Andreas Dilger [ 23/Dec/22 ]

Dongyang, is there any way to configure device mapper to have virtual T10-PI functionality so that we can test this without real hardware support?

Comment by Dongyang Li [ 23/Dec/22 ]

I spent some time last week trying to get dm-integrity working, and hopefully we can have some smoke testing cases e.g. sanity-integrity. But seems it's intended to work with dm-crypt,

the block device queue won't have integrity flags set, so not really useful for us.

Comment by Gerrit Updater [ 07/Jan/23 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49441/
Subject: LU-16413 osd-ldiskfs: fix T10PI for CentOS 8.x
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4f0273b3bc7d2159d255ea8ce8ec1804fa67bfd8

Comment by Peter Jones [ 07/Jan/23 ]

Landed for 2.16

Comment by Gerrit Updater [ 04/Apr/23 ]

"Li Dongyang <dongyangli@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50514
Subject: LU-16413 osd-ldiskfs: fix T10PI for CentOS 8.x
Project: fs/lustre-release
Branch: b2_15
Current Patch Set: 1
Commit: d05d52a4367380a9e02c7e8a786c3c78161b1c6f

Comment by Gerrit Updater [ 19/Apr/23 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50514/
Subject: LU-16413 osd-ldiskfs: fix T10PI for CentOS 8.x
Project: fs/lustre-release
Branch: b2_15
Current Patch Set:
Commit: daf49736a375daacde31f2250fced1fb486508c5

Generated at Sat Feb 10 03:26:48 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.