[LU-16460] fix lnetctl command line option bugs Created: 10/Jan/23  Updated: 19/Jan/23  Resolved: 19/Jan/23

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.16.0
Fix Version/s: Lustre 2.16.0

Type: Bug Priority: Major
Reporter: James A Simmons Assignee: James A Simmons
Resolution: Fixed Votes: 0
Labels: None
Environment:

Any LNet setup.


Issue Links:
Related
is related to LU-9680 Improve the user land to kernel space... In Progress
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

While moving LNet to netlink in my testing of different lnetctl command options bugs were exposed. Some of the bugs are:

1) A double free in the kernel when settting up a LNet NI for an interface that doesn' exis.t

2) NI tunables not being properly set.

3) A memory leak when registering a LNet NI twice.

4) Better range handling of user input and less strict failing for bad parameters.



 Comments   
Comment by Gerrit Updater [ 10/Jan/23 ]

"James Simmons <jsimmons@infradead.org>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49588
Subject: LU-16460 lnet: validate data sent from user land properly
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8006453e002be6a984c9b5f348ac358795d7365e

Comment by James A Simmons [ 10/Jan/23 ]

I still need to track down the memory leak in another patch.

Comment by Gerrit Updater [ 19/Jan/23 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49588/
Subject: LU-16460 lnet: validate data sent from user land properly
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 17a3b5688435ab5f78baef2fbdb7545d44a80aac

Comment by James A Simmons [ 19/Jan/23 ]

I also resolved the memory leak issue.

Generated at Sat Feb 10 03:27:13 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.