[LU-16520] CentOS 7.6 build failure on strscpy. Move strscpy to lnet/include/lnet/lib-types.h Created: 01/Feb/23  Updated: 14/Feb/23  Resolved: 14/Feb/23

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.16.0

Type: Bug Priority: Minor
Reporter: Shaun Tancheff Assignee: Shaun Tancheff
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Testing on CentOS 7.6 build fails with:

/home/shaun/lustre-release/lnet/klnds/o2iblnd/o2iblnd.c: In function ‘kiblnd_startup’:
/home/shaun/lustre-release/lnet/klnds/o2iblnd/o2iblnd.c:3608:3: error: implicit declaration of function ‘strscpy’ [-Werror=implicit-function-declaration]
   strscpy(ifname, ifaces[i].li_name, sizeof(ifname));
   ^

Move strscpy to lnet/include/lnet/lib-types.h so it is available to lnet/klnds/o2iblnd/o2iblnd.c

 Comments   
Comment by Gerrit Updater [ 01/Feb/23 ]

"Shaun Tancheff <shaun.tancheff@hpe.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49863
Subject: LU-16520 build: Move strscpy to common lnet header
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 374db0db7d81e88a3ec2de1d4acdb06edfcb2369

Comment by Gerrit Updater [ 14/Feb/23 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/49863/
Subject: LU-16520 build: Move strscpy to libcfs common header
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7fe7f4ca06b9c8d128f7ba36988e36f8141ed53d

Comment by Peter Jones [ 14/Feb/23 ]

Landed for 2.16

Generated at Sat Feb 10 03:27:43 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.