[LU-16549] osp_prep_update_req() packs OUT_UPDATE incorrectly Created: 10/Feb/23 Updated: 22/Mar/23 Resolved: 22/Mar/23 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.16.0 |
| Fix Version/s: | Lustre 2.16.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Nathaniel Clark | Assignee: | Vitaliy Kuznetsov |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
lustre/osp/osp_trans.c::osp_prep_update_req() req_capsule_set_size(&req->rq_pill, &RMF_OUT_UPDATE_HEADER, RCL_CLIENT, sizeof(struct osp_update_request)); req_capsule_set_size(&req->rq_pill, &RMF_OUT_UPDATE_BUF, RCL_CLIENT, buf_count * sizeof(*oub)); The first struct packed is actually a struct out_update_header with no inline data, so it should be packed as a length of 16, but gets packed as length 120 because of the size of struct osp_update_request (which should NEVER go over the wire). |
| Comments |
| Comment by Gerrit Updater [ 07/Mar/23 ] |
|
"Vitaliy Kuznetsov <vkuznetsov@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50224 |
| Comment by Gerrit Updater [ 21/Mar/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50224/ |
| Comment by Peter Jones [ 22/Mar/23 ] |
|
Landed for 2.16 |