[LU-16565] Remove ldlm flag ldlm_{is,set,clear} macros Created: 16/Feb/23 Updated: 17/Feb/23 |
|
| Status: | Open |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Patrick Farrell | Assignee: | Patrick Farrell |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
We have macros like ldlm_{is,set,clear}_#FLAG_NAME# for all of the ldlm flags. I'm going to remove them and convert all usages to just using the flag bit names directly. They make it much harder to find all uses of the actual lock flags and we are entirely inconsistent on whether we use the macros or not. And since we're always going to use the flag names for multi-flag uses, we can't convert 100% to macros anyway. |
| Comments |
| Comment by Gerrit Updater [ 16/Feb/23 ] |
|
"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50030 |
| Comment by Gerrit Updater [ 16/Feb/23 ] |
|
"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50031 |
| Comment by Gerrit Updater [ 16/Feb/23 ] |
|
"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50032 |
| Comment by Gerrit Updater [ 17/Feb/23 ] |
|
"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50044 |
| Comment by Gerrit Updater [ 17/Feb/23 ] |
|
"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50045 |
| Comment by Gerrit Updater [ 17/Feb/23 ] |
|
"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50046 |
| Comment by Gerrit Updater [ 17/Feb/23 ] |
|
"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50047 |
| Comment by Gerrit Updater [ 17/Feb/23 ] |
|
"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50049 |
| Comment by Gerrit Updater [ 17/Feb/23 ] |
|
"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50051 |
| Comment by Gerrit Updater [ 17/Feb/23 ] |
|
"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50052 |
| Comment by Gerrit Updater [ 17/Feb/23 ] |
|
"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50053 |
| Comment by Gerrit Updater [ 17/Feb/23 ] |
|
"Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50054 |