[LU-16599] clearing jobstats should match output format Created: 27/Feb/23  Updated: 02/Feb/24  Resolved: 29/Mar/23

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.16.0

Type: Improvement Priority: Minor
Reporter: Andreas Dilger Assignee: Feng Lei
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-16376 lprocfs_job_stats_log() Invalid jobid... Resolved
is related to LU-11407 Improve stats data Resolved
Rank (Obsolete): 9223372036854775807

 Description   

With the escaping of special characters in patch https://review.whamcloud.com/37764 "LU-11407 tgt: cleanup job_stats output printing" and truncation of log JobIds in patch https://review.whamcloud.com/49351 "LU-16376 obdclass: NUL terminate long jobid strings" it may be that the requested "clear" of a specific JobID in lprocfs_jobstats_seq_write(), considering that the format printed via "lctl get_param ..job_stats" does not match the internal name stored for the job.

The written JobID to clear should be de-quoted, un-escaped and then truncated to match the 32-char JobID that is stored internally in ojs_hash.



 Comments   
Comment by Gerrit Updater [ 01/Mar/23 ]

"Feng Lei <flei@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50160
Subject: LU-16599 obdclass: job_stats can parse escaped jobid string
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7a563c6094f80d5c9facb085590d7a3d838adc75

Comment by Gerrit Updater [ 28/Mar/23 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50160/
Subject: LU-16599 obdclass: job_stats can parse escaped jobid string
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8f004bc53b1a488dad5a92a580f5f0c078e33654

Comment by Peter Jones [ 29/Mar/23 ]

Landed for 2.16

Generated at Sat Feb 10 03:28:24 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.