[LU-166] MDR assert of wire dat for ATTR_BY_FID case

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.0.0, Lustre 2.1.0
• Fix Version/s: Lustre 2.1.0
• Type: Bug
• Priority: Minor
• Reporter: Oleg Drokin
• Assignee: nasf (Inactive)
• Resolution: Fixed
• Severity: 3

Description

mdt_getattr_name_lock has this code:

if (!info->mti_cross_ref) {
/*

• XXX: Check for "namelen == 0" is for getattr by fid
• (OBD_CONNECT_ATTRFID), otherwise do not allow empty name,
• that is the name must contain at least one character and
• the terminating '\0'
  */
  if (namelen == 0) {
  reqbody = req_capsule_client_get(info->mti_pill,
  &RMF_MDT_BODY);
  LASSERT(fid_is_sane(&reqbody->fid2));

This LASSERT is wrong because it depends on correctness of the client-supplied data.
Should be replaced with EPROTO error.

Comments

[nasf (Inactive)]

Right, the patch is in inspection:

http://review.whamcloud.com/#change,367

[Build Master (Inactive)]

Integrated in reviews-centos5 #575
LU-166 NOT assert wire data from client for getattr-by-fid

nasf : 2c7b04b817930a1b8e93d04d4cb809ee5691b191
Files :

• lustre/mdt/mdt_handler.c

[Build Master (Inactive)]

Integrated in lustre-master-centos5 #202
LU-166 NOT assert wire data from client for getattr-by-fid

Oleg Drokin : 88dd29f38769744eac20b06e1baac52872bf423f
Files :

• lustre/mdt/mdt_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » client,ubuntu-x86_64 #29
LU-166 NOT assert wire data from client for getattr-by-fid

Oleg Drokin : 88dd29f38769744eac20b06e1baac52872bf423f
Files :

• lustre/mdt/mdt_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » client,el5-x86_64 #29
LU-166 NOT assert wire data from client for getattr-by-fid

Oleg Drokin : 88dd29f38769744eac20b06e1baac52872bf423f
Files :

• lustre/mdt/mdt_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » client,el5-i686 #29
LU-166 NOT assert wire data from client for getattr-by-fid

Oleg Drokin : 88dd29f38769744eac20b06e1baac52872bf423f
Files :

• lustre/mdt/mdt_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » server,el6-x86_64 #29
LU-166 NOT assert wire data from client for getattr-by-fid

Oleg Drokin : 88dd29f38769744eac20b06e1baac52872bf423f
Files :

• lustre/mdt/mdt_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » client,el6-i686 #29
LU-166 NOT assert wire data from client for getattr-by-fid

Oleg Drokin : 88dd29f38769744eac20b06e1baac52872bf423f
Files :

• lustre/mdt/mdt_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » server,el5-x86_64 #29
LU-166 NOT assert wire data from client for getattr-by-fid

Oleg Drokin : 88dd29f38769744eac20b06e1baac52872bf423f
Files :

• lustre/mdt/mdt_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » client,el6-x86_64 #29
LU-166 NOT assert wire data from client for getattr-by-fid

Oleg Drokin : 88dd29f38769744eac20b06e1baac52872bf423f
Files :

• lustre/mdt/mdt_handler.c

[Build Master (Inactive)]

Integrated in lustre-master » server,el5-i686 #29
LU-166 NOT assert wire data from client for getattr-by-fid

Oleg Drokin : 88dd29f38769744eac20b06e1baac52872bf423f
Files :

• lustre/mdt/mdt_handler.c

[nasf (Inactive)]

Patch is landed.