[LU-16606] lnet_parse_route broken by LU-6142 lnet: use list_first_entry() in lnet/lnet subdirectory. Created: 01/Mar/23  Updated: 13/Mar/23  Resolved: 13/Mar/23

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.16.0

Type: Bug Priority: Critical
Reporter: Chris Horn Assignee: Chris Horn
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Regression in

commit 3b760208109b249fd9051d97dbc98664ca4b5769
Author: Mr NeilBrown <neilb@suse.de>
Date:   Mon May 30 20:43:12 2022 -0400

    LU-6142 lnet: use list_first_entry() in lnet/lnet subdirectory.

    Convert
      list_entry(foo->next .....)
    to
      list_first_entry(foo, ....)

    in 'lnet/lnet'

    In several cases the call is combined with
    a list_empty() test and list_first_entry_or_null() is used

    Test-Parameters: trivial testlist=sanity-lnet
    Change-Id: I45e1bdfe41854c88af98ebf24797f72a68b11dc3
    Signed-off-by: Mr NeilBrown <neilb@suse.de>
    Reviewed-on: https://review.whamcloud.com/47488
    Tested-by: jenkins <devops@whamcloud.com>
    Tested-by: Maloo <maloo@whamcloud.com>
    Reviewed-by: Chris Horn <chris.horn@hpe.com>
    Reviewed-by: Oleg Drokin <green@whamcloud.com>


 Comments   
Comment by James A Simmons [ 01/Mar/23 ]

which specific test is causing the failure? 

Comment by Gerrit Updater [ 01/Mar/23 ]

"Chris Horn <chris.horn@hpe.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50173
Subject: LU-16606 lnet: lnet_parse_route uses wrong loop var
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 96d86d6ae7b1abc6ef85b1c42726378e239e856e

Comment by Chris Horn [ 01/Mar/23 ]

I added a test case with the fix

Comment by Gerrit Updater [ 13/Mar/23 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50173/
Subject: LU-16606 lnet: lnet_parse_route uses wrong loop var
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0a414b1077a2f9dbc02539683453ae7dd729d5a7

Comment by Peter Jones [ 13/Mar/23 ]

Landed for 2.16

Generated at Sat Feb 10 03:28:27 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.