[LU-16661] recommend bash-completion for packages Created: 23/Mar/23 Updated: 13/Sep/23 Resolved: 26/Apr/23 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.16.0 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Andreas Dilger | Assignee: | Andreas Dilger |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||||||
| Description |
|
It would be good to add a "Recommends" or "Suggests" bash-completion to the lustre-client-utils and lustre-server-utils .deb packages (and also .rpm packages if that functionality exists today). The "lctl get_param" command greatly benefits from having bash-completion to provide parameter names, and the other "lctl" and "lfs" commands like "lfs find" and also have completions for many of options, added in I don't want to Depend or Require that package, but it should be installed when possible. I was recently debugging on a client node that didn't have bash-completion installed, and it was more painful than I would like, so regular users should also benefit from these improvements. |
| Comments |
| Comment by Gerrit Updater [ 24/Mar/23 ] |
|
"Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50396 |
| Comment by Gerrit Updater [ 24/Mar/23 ] |
|
"Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50397 |
| Comment by Gerrit Updater [ 04/Apr/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50396/ |
| Comment by Gerrit Updater [ 26/Apr/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50397/ |
| Comment by Peter Jones [ 26/Apr/23 ] |
|
Landed for 2.16 |
| Comment by Raphael Druon [ 04/Aug/23 ] |
|
This is causing issue with Ubuntu as it doesn't have the "linux-image" package installed but the "linux-image-generic" one. "linux-image-*-generic" does provide the "linux-image" package: root@co-es-pm-140:~/exa-client# dpkg -s linux-image-5.15.0-78-generic Package: linux-image-5.15.0-78-generic Status: install ok installed Priority: optional Section: kernel Installed-Size: 11348 Maintainer: Canonical Kernel Team <kernel-team@lists.ubuntu.com> Architecture: amd64 Source: linux-signed Version: 5.15.0-78.85 Provides: fuse-module, ivtv-modules, kvm-api-4, linux-image, redhat-cluster-modules, spl-dkms, spl-modules, v4l2loopback-dkms, v4l2loopback-modules, virtualbox-guest-modules, zfs-dkms, zfs-modules Depends: kmod, linux-base (>= 4.5ubuntu1~16.04.1), linux-modules-5.15.0-78-generic Recommends: grub-pc | grub-efi-amd64 | grub-efi-ia32 | grub | lilo, initramfs-tools | linux-initramfs-tool Suggests: fdutils, linux-doc | linux-source-5.15.0, linux-tools, linux-headers-5.15.0-78-generic, linux-modules-extra-5.15.0-78-generic Conflicts: linux-image-unsigned-5.15.0-78-generic Description: Signed kernel image generic A kernel image for generic. This version of it is signed with Canonical's signing key. Built-Using: linux (= 5.15.0-78.85) But this field is ignored when "Depends" is versioned as stated in the Debian policy manual
Could we add the "linux-image-generic" package in the dkms dependency in addition to the existing "linux-image*" one in "debian/control"? |
| Comment by Andreas Dilger [ 06/Aug/23 ] |
|
Raphael, probably best if you just submitted a patch directly, since you are in the best place to do it correctly and test it... |
| Comment by Raphael Druon [ 07/Aug/23 ] |
|
Thanks, I opened https://jira.whamcloud.com/browse/LU-17018 |
| Comment by Gerrit Updater [ 01/Sep/23 ] |
|
"Jian Yu <yujian@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52225 |
| Comment by Gerrit Updater [ 05/Sep/23 ] |
|
"Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/52281 |
| Comment by Gerrit Updater [ 13/Sep/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/52225/ |
| Comment by Gerrit Updater [ 13/Sep/23 ] |
|
"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/52281/ |