[LU-16723] Refactoring the parser Created: 08/Apr/23  Updated: 08/Jul/23  Resolved: 31/May/23

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.16.0

Type: Improvement Priority: Minor
Reporter: Tim Day Assignee: Tim Day
Resolution: Fixed Votes: 0
Labels: None

Rank (Obsolete): 9223372036854775807

 Description   

The parser code has a lot of unused complexity that can be streamlined. Refactor the parser makes the interface simpler from a development perspective and can provide a consistent user experience for all of the lustre utilities.

My main motivations:

  • Cut down cut duplication between all of the lustre utils
  • Make it easier to implement a git like help feature afterwards
  • Make it easier to implement testing over all possible commands (i.e. make sure every command has a help text or man page)


 Comments   
Comment by Gerrit Updater [ 08/Apr/23 ]

"Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/50583
Subject: LU-16723 libcfs: refactor parser to be simpler
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c882b65848b8b8d1098bc45974a0ecbba6ed0b22

Comment by Gerrit Updater [ 31/May/23 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/50583/
Subject: LU-16723 libcfs: refactor parser to be simpler
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 21080400f90e80d5864936465aa85830bee34131

Comment by Peter Jones [ 31/May/23 ]

Merged for 2.16

Comment by Gerrit Updater [ 16/Jun/23 ]

"Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51339
Subject: LU-16723 parser: fix help hanging
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 494ef209aaec11842b5a533d17f7305a3cdaf07f

Comment by Gerrit Updater [ 08/Jul/23 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/51339/
Subject: LU-16723 parser: fix help hanging
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0d77e94b47936f50a435aea623e4a12d812a696b

Generated at Sat Feb 10 03:29:27 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.