[LU-1693] filter_do_bio() and osd_do_bio() should set bi_rw before calling bio_add_page() Created: 31/Jul/12 Updated: 22/Dec/12 Resolved: 31/Aug/12 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.1.0, Lustre 2.2.0, Lustre 2.3.0 |
| Fix Version/s: | Lustre 2.3.0, Lustre 2.4.0, Lustre 2.1.4 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | WC Triage |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | obdfilter, osd-ldiskfs, patch | ||
| Severity: | 3 |
| Rank (Obsolete): | 4469 |
| Description |
|
filter_do_bio() calls bio_add_page() without setting the direction of the bio. In bio_add_page() the direction is passed on to the merge_bvec_fn() if defined. raid5_mergeable_bvec() does check the direction and setting it correctly improves write bandwidth by allowing for full stripe writes. I assume that this is equally true of osd_do_bio(). |
| Comments |
| Comment by John Hammond [ 31/Jul/12 ] |
|
Please see http://review.whamcloud.com/3501. |
| Comment by Peter Jones [ 31/Aug/12 ] |
|
Landed for 2.3 and 2.4 |
| Comment by Emoly Liu [ 07/Dec/12 ] |
|
b2_1 port is at http://review.whamcloud.com/4765 |