[LU-16969] Remove the PKG_CHECK_MODULE macro Created: 19/Jul/23  Updated: 01/Aug/23  Resolved: 01/Aug/23

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.16.0

Type: Improvement Priority: Minor
Reporter: Tim Day Assignee: Tim Day
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

This macro fails in very annoying to debug ways, without providing any benefit over a plan pkg-config command. Often, this will fail with:

syntax error near unexpected token `LIBNL3,'

`      PKG_CHECK_MODULES(LIBNL3, libnl-genl-3.0 >= 3.1)'

and provide no indication that the real error is that pkg-config is not installed. Using the raw command will make this self-evident will still performing the same function.



 Comments   
Comment by Gerrit Updater [ 19/Jul/23 ]

"Timothy Day <timday@amazon.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/51716
Subject: LU-16969 build: remove PKG_CHECK_MODULES
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d496ab117c00c11afdbcda626fa1e6a612431bbe

Comment by Gerrit Updater [ 01/Aug/23 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/51716/
Subject: LU-16969 build: check that pkg-config is installed
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 94a32720c9977787dba929b522638fd9de3b10b1

Comment by Peter Jones [ 01/Aug/23 ]

Landed for 2.16

Generated at Sat Feb 10 03:31:30 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.