[LU-17143] Use migrate_copy_data() for all data movement Created: 25/Sep/23 Updated: 25/Sep/23 |
|
| Status: | Open |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Andreas Dilger | Assignee: | WC Triage |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
The "lfs mirror resync" code is using its own implementation of data copying instead of migrate_copy_data(), which means that bug fixes and improvements to the data copying code (eg. bandwidth limit, stats reporting, buffer sizing, DIO usage, etc.) need to be implemented in two places. It would be better to have a single function to copy file data shared between the different operations. |
| Comments |
| Comment by Patrick Farrell [ 25/Sep/23 ] |
|
migrate_copy_data is by far the most complex of the various copy functions, so we should start there, though it doesn't have any parallelism in it. |