[LU-17166] add TBF rule for projid

• Status: Open
• Project: Lustre
• Type: Improvement
• Priority: Minor
• Reporter: Andreas Dilger
• Assignee: Etienne Aujames
• Resolution: Unresolved
• Labels: easy
• Severity: 3

Description

It appears that there was no rule added for NRS TBF to allow selecting the project ID for an RPC.

Issue Links

• is related to: LU-9658 Add QoS for uid and gid in NRS-TBF

Comments

[Stephane Thiell]

YES! Would be great to have. We're interested to use this on a system instead of NRS TBF GID.

[Andreas Dilger]

sthiell, contributions are of course welcome. I don't think this would be more than a cargo-cult copying of the uid/gid/jobid functionality that already exists, so likely very low complexity.

[Etienne Aujames]

Hi Andreas,

projid is not in every RPCs (present in mdt_body but for the OSTs this used in quota requests only), so we can use a free field in ptlrpc_body (e.g: pb_padding64_1) to tag the requests and add a new compatibility flag.
And unlike for uid/gid, we can not take the ids of the process because project id is only an attr. I think we can access to the projid via the inode information on the clients: (struct ll_inode_info *) ->lli_projid

[Andreas Dilger]

The struct obdo::o_projid field should be included in almost every OST RPC? I could imagine that there may be cases where it is not set by the client, but that can be fixed in the client.

[Etienne Aujames]

Ok, that should work for ost_io service.
For now, o_projid is set only for write request, but we can modify the client to send it for write and read.
So for now, we could restrict the development to ost_io (that should be easy).
But for ost and mdt services, that should require more work on the client to include projid in the requests.