[LU-17438] Fix the compilation of wirecheck Created: 17/Jan/24  Updated: 17/Jan/24

Status: Open
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Etienne Aujames Assignee: Etienne Aujames
Resolution: Unresolved Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

wirecheck no longer builds:

eaujames@dev:~/lustre-release/lustre/utils$ make wirecheck                                                                                                                                             [498/498]
gcc -DHAVE_CONFIG_H -I. -I../..  -DCC="\"gcc\"" -include /home/eaujames/lustre-release/undef.h -include /home/eaujames/lustre-release/config.h -I/home/eaujames/lustre-release/lnet/include/uapi -I/home/eaujames/l
ustre-release/lustre/include/uapi -I/home/eaujames/lustre-release/libcfs/include -I/home/eaujames/lustre-release/lnet/utils/ -I/home/eaujames/lustre-release/lustre/include  -fPIC -D_GNU_SOURCE -D_LARGEFILE64_SOU
RCE=1 -D_FILE_OFFSET_BITS=64 -DLUSTRE_UTILS=1  -g -O2 -Wall -Werror  -MT wirecheck-wirecheck.o -MD -MP -MF .deps/wirecheck-wirecheck.Tpo -c -o wirecheck-wirecheck.o `test -f 'wirecheck.c' || echo './'`wirecheck.
c
wirecheck.c: In function ‘check_lov_foreign_md’:
wirecheck.c:881:16: error: ‘LU_FOREIGN_TYPE_DAOS’ undeclared (first use in this function)
  CHECK_VALUE_X(LU_FOREIGN_TYPE_DAOS);
                ^
wirecheck.c:104:36: note: in definition of macro ‘CHECK_VALUE_X’
   " (unsigned)"#a");\n", (unsigned)a); \
                                    ^
wirecheck.c:881:16: note: each undeclared identifier is reported only once for each function it appears in
  CHECK_VALUE_X(LU_FOREIGN_TYPE_DAOS);
                ^
wirecheck.c:104:36: note: in definition of macro ‘CHECK_VALUE_X’
   " (unsigned)"#a");\n", (unsigned)a); \
                                    ^
wirecheck.c: In function ‘check_lov_hsm_base’:
wirecheck.c:891:2: error: implicit declaration of function ‘BLANK_LINKE’ [-Werror=implicit-function-declaration]
  BLANK_LINKE();
  ^
wirecheck.c: In function ‘check_rsi_downcall_data’:
wirecheck.c:169:27: error: invalid application of ‘sizeof’ to incomplete type ‘struct rsi_downcall_data’
   CHECK_VALUE((int)sizeof(struct s));  \
....


 Comments   
Comment by Etienne Aujames [ 17/Jan/24 ]

I think wirecheck should be built along with all the utils. That way, developers will see if they break something in wirecheck code.

Comment by Gerrit Updater [ 17/Jan/24 ]

"Etienne AUJAMES <eaujames@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/53716
Subject: LU-17438 utils: fix build for wirecheck
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: be6db26a83b4f6f269797dafff6a2ad91d461ab2

Generated at Sat Feb 10 03:35:26 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.