[#LU-175] mdt_lproc.c:255: error: the frame size of 1040 bytes is larger than 1024 bytes

[LU-175] mdt_lproc.c:255: error: the frame size of 1040 bytes is larger than 1024 bytes Created: 28/Mar/11 Updated: 25/Apr/11 Resolved: 25/Apr/11
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	Lustre 2.1.0
Fix Version/s:	Lustre 2.1.0

Type:

Bug

Priority:

Minor

Reporter:

Brian Murrell (Inactive)

Assignee:

Brian Murrell (Inactive)

Resolution:

Fixed

Votes:

Labels:

None

Environment:

i686 server build

Severity:

Rank (Obsolete):

5061

Description

http://build.whamcloud.com/job/lustre-reviews/build_type=server,distro=el6/10/consoleFull:

/var/lib/jenkins/workspace/lustre-reviews/build_type/server/distro/el6/BUILD/BUILD/lustre-2.0.59/lustre/mdt/mdt_lproc.c: In function 'lprocfs_wr_identity_upcall':
/var/lib/jenkins/workspace/lustre-reviews/build_type/server/distro/el6/BUILD/BUILD/lustre-2.0.59/lustre/mdt/mdt_lproc.c:255: error: the frame size of 1040 bytes is larger than 1024 bytes
make[6]: *** [/var/lib/jenkins/workspace/lustre-reviews/build_type/server/distro/el6/BUILD/BUILD/lustre-2.0.59/lustre/mdt/mdt_lproc.o] Error 1
make[5]: *** [/var/lib/jenkins/workspace/lustre-reviews/build_type/server/distro/el6/BUILD/BUILD/lustre-2.0.59/lustre/mdt] Error 2
make[4]: *** [/var/lib/jenkins/workspace/lustre-reviews/build_type/server/distro/el6/BUILD/BUILD/lustre-2.0.59/lustre] Error 2
make[3]: *** [_module_/var/lib/jenkins/workspace/lustre-reviews/build_type/server/distro/el6/BUILD/BUILD/lustre-2.0.59] Error 2

Comments

Comment by Johann Lombardi (Inactive) [ 30/Mar/11 ]

It seems that we allocate too much on the stack:

static int lprocfs_wr_identity_upcall(struct file *file, const char *buffer,
unsigned long count, void *data)
{
struct obd_device *obd = data;
struct mdt_device *mdt = mdt_dev(obd->obd_lu_dev);
struct upcall_cache *hash = mdt->mdt_identity_cache;
char kernbuf[UC_CACHE_UPCALL_MAXPATH] =

{ '\0' }

;
...

with #define UC_CACHE_UPCALL_MAXPATH (1024UL)

One way to address the problem would be to allocate kernbuf with OBD_ALLOC() (as done in lprocfs_wr_nosquash_nids() for instance).

Comment by Build Master (Inactive) [ 04/Apr/11 ]

Integrated in lustre-reviews » client,el5-x86_64 #66
~~LU-175~~ don't allocate kernbuf on the stack

Brian J. Murrell : 51b5c124fbc213427a530f51c62dad573396dd0b
Files :

lustre/mdt/mdt_lproc.c

Comment by Build Master (Inactive) [ 04/Apr/11 ]

Integrated in lustre-reviews » client,el6-x86_64 #66
~~LU-175~~ don't allocate kernbuf on the stack

Brian J. Murrell : 51b5c124fbc213427a530f51c62dad573396dd0b
Files :

lustre/mdt/mdt_lproc.c

Comment by Build Master (Inactive) [ 04/Apr/11 ]

Integrated in lustre-reviews » client,ubuntu-x86_64 #66
~~LU-175~~ don't allocate kernbuf on the stack

Brian J. Murrell : 51b5c124fbc213427a530f51c62dad573396dd0b
Files :

lustre/mdt/mdt_lproc.c

Comment by Build Master (Inactive) [ 04/Apr/11 ]

Integrated in lustre-reviews » server,el5-i686 #66
~~LU-175~~ don't allocate kernbuf on the stack

Brian J. Murrell : 51b5c124fbc213427a530f51c62dad573396dd0b
Files :

lustre/mdt/mdt_lproc.c