[LU-1787] osc_setup doesn't return rc in all cases Created: 27/Aug/12  Updated: 27/Aug/12  Resolved: 27/Aug/12

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.3.0, Lustre 2.4.0
Fix Version/s: None

Type: Bug Priority: Critical
Reporter: James A Simmons Assignee: Bob Glossman (Inactive)
Resolution: Duplicate Votes: 0
Labels: None

Issue Links:
Duplicate
duplicates LU-1691 kernel update [SLES11 SP2 3.0.34-0.7.9] Resolved
Severity: 3
Rank (Obsolete): 6344

 Description   

Found a misreported error state for the osc_setup function.

 Comments   
Comment by James A Simmons [ 27/Aug/12 ]

Patch for master at http://review.whamcloud.com/#change,3789

Comment by James A Simmons [ 27/Aug/12 ]

Patch for branch b2_3 at http://review.whamcloud.com/#change,3790

Comment by Peter Jones [ 27/Aug/12 ]

Thanks for the patch James.

Bob could you please see that this patch get reviewed and autotested - thanks

Comment by Bob Glossman (Inactive) [ 27/Aug/12 ]

James, Can you provide a little more information about what trips over this flaw? We want to know how it's triggered or reproduced.

Comment by James A Simmons [ 27/Aug/12 ]

Sure.

CC [M] /tmp/jsimmons-suse/rpmbuild/usr/src/lustre-2.3.50/lustre/osc/osc_request.o
cc1: warnings being treated as errors
/tmp/jsimmons-suse/rpmbuild/usr/src/lustre-2.3.50/lustre/osc/osc_request.c: In function ‘osc_setup’:
/tmp/jsimmons-suse/rpmbuild/usr/src/lustre-2.3.50/lustre/osc/osc_request.c:3576: error: ignoring return value of ‘PTR_ERR’, declared with attribute warn_unused_result

gcc -v
Using built-in specs.
Target: x86_64-suse-linux
Configured with: ../configure -prefix=/usr --infodir=/usr/share/info --mandir=/usr/share/man --libdir=/usr/lib64 --libexecdir=/usr/lib64 --enable-languages=c,c+,objc,fortran,obj-c,java,ada --enable-checking=release --with-gxx-include-dir=/usr/include/c+/4.3 --enable-ssp --disable-libssp --with-bugurl=http://bugs.opensuse.org/ --with-pkgversion='SUSE Linux' --disable-libgcj --disable-libmudflap --with-slibdir=/lib64 --with-system-zlib --enable__cxa_atexit --enable-libstdcxx-allocator=new --disable-libstdcxx-pch --enable-version-specific-runtime-libs --program-suffix=-4.3 --enable-linux-futex --without-system-libunwind --with-cpu=generic --build=x86_64-suse-linux
Thread model: posix
gcc version 4.3.4 [gcc-4_3-branch revision 152973] (SUSE Linux)

This is a non-cray platform.

Comment by James A Simmons [ 27/Aug/12 ]

Also this is being built against a 3.0+ kernel.

Comment by Bob Glossman (Inactive) [ 27/Aug/12 ]

duplicates work already in progress by Yang Sheng

Comment by James A Simmons [ 27/Aug/12 ]

Okay. In that case I will move to that patch. Thanks.

Comment by James A Simmons [ 27/Aug/12 ]

Peter you can close this ticket as a duplicate. Thank you.

Comment by Peter Jones [ 27/Aug/12 ]

ok thanks James.

Generated at Sat Feb 10 01:19:41 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.