VLA error:
drivers/incore/fs_incore.c:340:54: error: variably modified
‘incore_dir_template’ at file scope [-Werror]
$gcc --version
gcc (GCC) 4.6.3 20120306 (Red Hat 4.6.3-2)
Copyright (C) 2011 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
patch submitted:
http://review.whamcloud.com/3856
Another error after rebasing my code...
make[3]: Entering directory `/home/bergwolf/src/linux-2.6'
WARNING: Symbol version dump /home/bergwolf/src/linux-2.6/Module.symvers
is missing; modules will have no dependencies and modversions.
CC [M] /home/bergwolf/rpmbuild/BUILD/lustre-2.3.50/lustre/osc/osc_request.o
cc1: warnings being treated as errors
/home/bergwolf/rpmbuild/BUILD/lustre-2.3.50/lustre/osc/osc_request.c: In function ‘osc_setup’:
/home/bergwolf/rpmbuild/BUILD/lustre-2.3.50/lustre/osc/osc_request.c:3581: error: ignoring return value of ‘PTR_ERR’, declared with attribute warn_unused_result
$gcc --version
gcc (GCC) 4.4.6 20120305 (Red Hat 4.4.6-4)
Copyright (C) 2010 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
patch submitted to
http://review.whamcloud.com/3884
This is the same problem we seen on SLES11 SP2. Please take a look at http://review.whamcloud.com/#change,3734 for jira ticket LU-1691. This is really a duplicate of that ticket.
LU-1691 doesn't address the VLA error. Shall I abandon this ticket (and the two patches) and let Yang Sheng fold the VLA part into http://review.whamcloud.com/#change,3734 ?
Look at the LU-1691 patch and your two patches I would suggest the easiest path is to fold your changes into one patch and make it dependent on the patch from LU-1691 since they over lap. You are right your patch adds even more fixes that are needed beyond SLES11 SP2 support.
I agree. I'll just abandon http://review.whamcloud.com/#change,3884 and reduce http://review.whamcloud.com/#change,3856 to just fix VLA error. There is no need to depend on patch from LU-1691 because VLA fix is independent. Thanks.
Landed for 2.3
Found another problem. Could we reopen and keep this ticket around? We will continue to have gcc build errors from time to time.
James
It makes it much easier to track which fix is in which release if we have one ticket per issue rather than reused tickets (and I bet it takes less time to open a new ticket than to find the existing one to reuse
). My preference would be for us to look into ways that we can catch introducing these problems before they land. Perhaps we can discuss ideas on how we could accomplish this on the next CDWG call?
Peter
Okay. Its under LU-2111