[LU-1884] Coverity: Fix 'resource leak' errors

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.4.0, Lustre 2.1.3
• Fix Version/s: Lustre 2.3.0, Lustre 2.4.0
• Type: Technical task
• Priority: Major
• Reporter: Sebastien Buisson (Inactive)
• Assignee: Bob Glossman (Inactive)
• Resolution: Fixed
• Labels: build, coverity

Description

Thanks to the Coverity tool, we found some resource leak errors in the Lustre code. This is typically what happens when a function forgets to free some allocated memory or close some file descriptor while returning in case of error.

I will propose a patch to address the issues.

Issue Links

• is related to: LU-2644 Fix 'resource leak' errors
• is related to: LU-17000 Coverity static analysis issues

Comments

[Sebastien Buisson (Inactive)]

The patch is available here:

http://review.whamcloud.com/3934

Could you please review it?

[Peter Jones]

Thanks Sebastien. Bob, another one to take care of - thanks!

[Jodi Levi (Inactive)]

Please let me know if this ticket needs to be reopened.

[Sebastien Buisson (Inactive)]

Hi,
I would like to reopen this ticket, as Coverity has found new 'resource leak' errors in more recent code (2.3.58).

[Sebastien Buisson (Inactive)]

I have posted a new patch:
http://review.whamcloud.com/5128

TIA,
Sebastien.

[Peter Jones]

Rather than reopen this ticket it would be better to open a new ticket to track the changes needed in more recent code.

[Sebastien Buisson (Inactive)]

By opening a new ticket, I was afraid that all changes related to this 'resource leak' thing were spread among various tickets, hence making it difficult to track.

[Peter Jones]

Yes but we can link tickets together and avoid possible support confusion. The original reported issue was fixed in 2.3. Reopening this ticket in relation to code landed after 2.3 might suggest otherwise.

[Sebastien Buisson (Inactive)]

All right.
I have abandoned the modifications at http://review.whamcloud.com/5128, and I have opened a new ticket, LU-2644. Can you please make a link between these two Jiras?