[LU-1888] e2fsprogs: mke2fs does not apply specified mmp_update_interval option Created: 11/Sep/12  Updated: 05/Dec/12  Resolved: 05/Dec/12

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Gregoire Pichon Assignee: Jian Yu
Resolution: Fixed Votes: 0
Labels: None
Environment:

e2fsprogs-1.42.3.wc3


Severity: 3
Epic: e2fsprogs, mke2fs, mmp
Rank (Obsolete): 6331

 Description   

When specifying the mmp_update_interval option, mke2fs command does not take it into account and initialize the filesystem with the default value (5 seconds).

mke2fs -j -b 4096 -L fsperf-OST0000 -j -J device=/dev/ldn.sfa10kt.jp22 -m 0  -I 256 -i 524288  -O extents,uninit_bg,mmp,dir_nlink,huge_file,flex_bg -G 256 -E lazy_itable_init=0,lazy_journal_init=0,mmp_update_interval=10,resize=4290772992 -F /dev/ldn.sfa10kt.dp22 1891631104
                                                                                                                                                                                                     ^^^^^^^^^^^^^^^^^^^^^^
mke2fs 1.42.3.wc3 (15-Aug-2012)
Filesystem label=fsperf-OST0000
OS type: Linux
Block size=4096 (log=2)
Fragment size=4096 (log=2)
Stride=0 blocks, Stripe width=0 blocks
14778368 inodes, 1891631104 blocks
0 blocks (0.00%) reserved for the super user
First data block=0
Maximum filesystem blocks=4290772992
57728 block groups
32768 blocks per group, 32768 fragments per group
256 inodes per group
Superblock backups stored on blocks: 
	32768, 98304, 163840, 229376, 294912, 819200, 884736, 1605632, 2654208, 
	4096000, 7962624, 11239424, 20480000, 23887872, 71663616, 78675968, 
	102400000, 214990848, 512000000, 550731776, 644972544

Allocating group tables: done                            
Writing inode tables: done                            
Adding journal to device /dev/ldn.sfa10kt.jp22: done
Multiple mount protection is enabled with update interval 5 seconds.    <================
Writing superblocks and filesystem accounting information: done       

Looking at the code, the command parameters are correctly parsed by the value stored in fs_param->s_mmp_update_interval is not transmitted to the filesystem superblock descriptor: fs->super->s_mmp_update_interval.

I will provide a patch.



 Comments   
Comment by Gregoire Pichon [ 11/Sep/12 ]

Here is a proposal patch: http://review.whamcloud.com/3938

Comment by Peter Jones [ 11/Sep/12 ]

Thanks for the patch Gregoire. Yujian could you please take care of getting this patch landed?

Comment by Jian Yu [ 02/Nov/12 ]

Status update: building e2fsprogs is blocked by LU-1606.

Comment by Jian Yu [ 26/Nov/12 ]

Status update: building e2fsprogs passed, the patch is pending reviewing and landing.

Comment by Peter Jones [ 05/Dec/12 ]

Landed

Generated at Sat Feb 10 01:20:34 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.