[LU-1901] compile error for sles11 when JBD2_DEBUG is on

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 1.8.8
• Fix Version/s: Lustre 1.8.9
• Type: Bug
• Priority: Trivial
• Reporter: Vladimir V. Saveliev
• Assignee: Bob Glossman (Inactive)
• Resolution: Fixed

Environment

SLES11

• Bugzilla ID: 24,636

Description

For sles11 lustre expands s_mount_opts to unsigned long long:

ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch:

@@ -997,7 +1004,7 @@ struct ext4_sb_info {
struct buffer_head * s_sbh; /* Buffer containing the super block */
struct ext4_super_block s_es; / Pointer to the super block in the buffer */
struct buffer_head **s_group_desc;

• unsigned int s_mount_opt;
  + unsigned long long s_mount_opt; /* lustre need more options */
  unsigned int s_mount_flags;
  ext4_fsblk_t s_sb_block;
  uid_t s_resuid;

but does not update printk's specifier in fs/ext4/inode.c:ext4_forget()
jbd_debug(4, "forgetting bh %p: is_metadata = %d, mode %o, "
"data mode %x\n",
bh, is_metadata, inode->i_mode,
test_opt(inode->i_sb, DATA_FLAGS));

test_opt(inode->i_sb, DATA_FLAGS) is unsigned long long now, so it should be printed as %Lx

Comments

[Vladimir V. Saveliev]

http://review.whamcloud.com/3943

[Peter Jones]

Thanks VS!

Yangsheng

Could you please look into getting this patch landed?

Thanks

Peter

[Peter Jones]

Reassigning to Bob

[Johann Lombardi (Inactive)]

Bob, is the patch also needed on master?

[Bob Glossman (Inactive)]

Johann, since we only support clients in sles11 on master this patch isn't needed there. We probably need much bigger revisions to the ldiskfs patch set for sles11 than just this to revive server support for sles11 in master.

[James A Simmons]

The patch for this ticket is for SLES11 SP0 so its not needed for master. Officially master support SLES11 SP1 clients but the work (i.e ldiskfs) is there to support server side. Also the patch from LU-1812 will allow true SLES11 SP1 support. SLES11 SP2 without ldiskfs will be possible also.