[LU-1935] Build warning for lustre/scripts directory

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.4.0
• Type: Bug
• Priority: Minor
• Reporter: Andreas Dilger
• Assignee: Ned Bass
• Resolution: Fixed
• Severity: 3

Description

Since the landing of LU-105 "Add scripts for implementing heartbeat v1 failover" (commit hash 04a38ba7cda4e242850a47b13d4402a69e8dd921) there has been a build warning in the lustre/scripts directory:

lustre/scripts/Makefile:740: warning: overriding commands for target `lustre'
$(genscripts): %: %.in
        sed -e 's#@scriptlibdir@#$(scriptlibdir)#' < $< > $@
        chmod +x $@
lustre/scripts/Makefile:389: warning: ignoring old commands for target `lustre'
lustre: $(top_builddir)/config.status $(srcdir)/lustre.in
        cd $(top_builddir) && $(SHELL) ./config.status $(subdir)/$@

This was caused by the addition of lustre to the genscripts variable. I don't know if this is serious or not, but I suspect something isn't working as it should be.

Comments

[Ned Bass]

A quick fix would be to just remove lustre from genscripts. The genscripts target (1) expands the @scriptlibdir@ token, which the lustre script doesn't use, and (2) adds execute permission, which is otherwise handled by 'make install'.

However, I think a better fix would be to convert lustre.in from an auto-generated file to a static one. We generate it to expand @PFSCK@ and @TUNE2FS@ for ldiskfsprogs support, but we could just use /sbin/

{pfsck,tunefs}

.ldiskfs if they exist, otherwise use the e2fsprogs versions. This is similar to what we did for test-framework.sh.

[Ned Bass]

http://review.whamcloud.com/#change,4015