[LU-1965] Lustre --disable-liblustre broken Created: 17/Sep/12  Updated: 18/Sep/12  Resolved: 17/Sep/12

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Henri Doreau (Inactive) Assignee: Minh Diep
Resolution: Duplicate Votes: 0
Labels: build, patch

Attachments: Text File disable_liblustre-fix.patch    
Severity: 2
Rank (Obsolete): 6322

 Description   

Compilation with --disable-liblustre is broken. According to git bisect, the regression was introduced by commit bfb38a047e0fc12e68a7aa3a2d2ec7a6e9d696ed.

The patch attached, generated against master, seems to fix the issue.



 Comments   
Comment by Peter Jones [ 17/Sep/12 ]

Henri

Thanks for the patch. Could you please upload the patch into gerrit so that we can review/test/land it? There are instructions relating to this on the Whamcloud wiki and your colleagues should be able to provide guidance on how to set this up if you need it.

Minh

Could you please take care of landing this fix once it is available in gerrit?

Thanks

Peter

Comment by Henri Doreau (Inactive) [ 17/Sep/12 ]

Peter,

thanks, I've pushed my changes to Gerrit. Please let me know if not everything is in order.

http://review.whamcloud.com/#change,4010

Comment by Peter Jones [ 17/Sep/12 ]

Yes - thanks Henri!

Comment by Andreas Dilger [ 17/Sep/12 ]

I think there is already a patch for this, but I can't search for it right now on my phone.

Comment by Andreas Dilger [ 17/Sep/12 ]

This is already being fixed in LU-1905, though it seems that patch hasn't landed yet. A comment in the patch (http://review.whamcloud.com/3953) should help it move along, which I would do now except I'm travelling.

LU-1905 build: Always create libcfs.a

Lustre and LNET utilites have become dependent on libcfs.a but
one can easily disable libcfs.a from being built by disabling
liblustre creation. This patch have Lustre always build libcfs.a.

Signed-off-by: James Simmons <uja.ornl@gmail.com>
Change-Id: Id80f9baa16da238eca708409e0b5d5248e437c5a

Cheers, Andreas

Andreas Dilger Whamcloud, Inc.
Principal Lustre Engineer http://www.whamcloud.com/

Comment by Peter Jones [ 17/Sep/12 ]

The fix from LU-1905 has now been landed to master. Please speak up if the problem still remains now.

Comment by Henri Doreau (Inactive) [ 18/Sep/12 ]

The fix from LU-1905 works like a charm.
Sorry for the noise!

Generated at Sat Feb 10 01:21:13 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.