[LU-2000] tune2fs -p no longer working

• Status: Resolved
• Project: Lustre
• Type: Bug
• Priority: Minor
• Reporter: Shuichi Ihara (Inactive)
• Assignee: Andreas Dilger
• Resolution: Not a Bug
• Labels: tune2fs

Environment

redhat 5

• Severity: 3

Description

The tune2fs -p option appears to be broken in the latest e2fsprogs.

[root@victrix-oss0 ~]# tune2fs -p 8 /dev/mapper/ost_v_0
tune2fs 1.42.3.wc3 (15-Aug-2012)
tune2fs: invalid option – p
Usage: tune2fs [-c max_mounts_count] [-e errors_behavior] [-g group]
[-i interval[d|m|w]] [-j] [-J journal_options] [-l]
[-m reserved_blocks_percent] [-o [^]mount_options[,...]] [-p mmp_update_interval]
[-r reserved_blocks_count] [-u user] [-C mount_count] [-L volume_label]
[-M last_mounted_dir] [-O [^]feature[,...]]
[-E extended-option[,...]] [-T last_check_time] [-U UUID]
[ -I new_inode_size ] device
[root@victrix-oss0 ~]# echo $?
1
[root@victrix-oss0 ~]# dumpe2fs /dev/mapper/ost_v_0 | grep -i MMP
dumpe2fs 1.42.3.wc3 (15-Aug-2012)
Filesystem features: has_journal ext_attr resize_inode dir_index filetype extent mmp flex_bg sparse_super large_file huge_file uninit_bg dir_nlink
MMP block number: 1037
MMP update interval: 5
[root@victrix-oss0 ~]# rpm -qf `which tune2fs`
e2fsprogs-1.42.3.wc3-0redhat
[root@victrix-oss0 ~]#

Comments

[Peter Jones]

Andreas

Could you please comment on this one?

Thanks

Peter

[Kit Westneat (Inactive)]

I did a little research, and comparing this commit:
http://git.whamcloud.com/?p=tools/e2fsprogs.git;a=commitdiff;h=0f5eba7501f467f757792ee449d16c9259b994fd

To this old patch:
http://lists.openwall.net/linux-ext4/2011/04/04/8

It looks like the short option was removed and converted to an extended option, "mmp_update_interval", but the documentation was never changed.

Through gitweb at least, it's hard to keep track of changes to the patches. Is there a way to track that? I am guessing not currently, since it appears that there is basically a set of patches that are constantly rebased on top of master. At least I don't see any history of moving from the 4/11 patch to the 9/11 commit through gitweb.

[Peter Jones]

It seems like this actual issue is understood now but it would have been useful if the change in the flags had been documented in release notes to warn users.