[LU-2068] configure option "--without-ldiskfs" does not build. Created: 01/Oct/12 Updated: 19/Apr/13 Resolved: 08/Oct/12 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.4.0 |
| Fix Version/s: | Lustre 2.4.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | Prakash Surya (Inactive) | Assignee: | Minh Diep |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Lustre Tree: 2.3.51-7-g1d7fa63 |
||
| Severity: | 3 |
| Rank (Obsolete): | 4318 |
| Description |
|
I run into build issues with the "lvfs" directory and the "osd-ldiskfs" directory if I configure the tree using the "--without-ldiskfs" option. |
| Comments |
| Comment by Prakash Surya (Inactive) [ 01/Oct/12 ] |
|
To start, it looks like my patches from |
| Comment by Prakash Surya (Inactive) [ 01/Oct/12 ] |
|
Pushed an initial patch to remedy this here: http://review.whamcloud.com/4148 |
| Comment by Alex Zhuravlev [ 02/Oct/12 ] |
|
thanks for the patch. I've slightly modified it so that: 1) utilities (mkfs/mount) do not try to call ldiskfs helpers |
| Comment by James A Simmons [ 02/Oct/12 ] |
|
Would you mind if I add in the top autoMakefile.am fix for the META for ldisk? |
| Comment by Alex Zhuravlev [ 02/Oct/12 ] |
|
not at all. thanks! |
| Comment by James A Simmons [ 02/Oct/12 ] |
|
Last patch is pretty broken. Is mds and cmm used only for ldisk non-osd mode? I included them back in for server build or should they be only ldiskfs? |
| Comment by Alex Zhuravlev [ 02/Oct/12 ] |
|
no, neither mds nor cmm are used with any backend. |
| Comment by Alex Zhuravlev [ 02/Oct/12 ] |
|
i'm uploading a new version just to see how the build system like it.. |
| Comment by James A Simmons [ 02/Oct/12 ] |
|
Trying it as well. |
| Comment by Alex Zhuravlev [ 02/Oct/12 ] |
|
James, there is a small defect still in the code (preventing few conf-sanity tests), I'll upload fixed version shortly. |
| Comment by James A Simmons [ 02/Oct/12 ] |
|
Client build seems to be having a issue as well. |
| Comment by Alex Zhuravlev [ 02/Oct/12 ] |
|
fixing.. |
| Comment by James A Simmons [ 02/Oct/12 ] |
|
Found the last build bug on client. Will be pushing a patch soon. |
| Comment by Alex Zhuravlev [ 02/Oct/12 ] |
|
I'll have to update the patch after that. thanks in advance. |
| Comment by James A Simmons [ 02/Oct/12 ] |
|
Just submitted. All yours now. |
| Comment by James A Simmons [ 02/Oct/12 ] |
|
Almost. Only the ZFS build now fails. What is missing is: diff --git a/lustre/obdfilter/autoMakefile.am b/lustre/obdfilter/autoMakefile.am if MODULES MOSTLYCLEANFILES := @MOSTLYCLEANFILES@ |
| Comment by Christopher Morrone [ 02/Oct/12 ] |
|
Could you explain why ZFS needs that? As of 2.3.51 we are building lustre --without-ldiskfs and --with-zfs and did not see a build problem. In any event, the obdfilter code will be deleted in about a week, as I understand it, so I don't much care either way. |
| Comment by James A Simmons [ 02/Oct/12 ] |
|
The last patch for this ticket was trying to build obdfilter for zfs which is not needed. |
| Comment by Alex Zhuravlev [ 02/Oct/12 ] |
|
Chris, this is not just obdfilter - it's llog-lvfs code which I'd like to avoid from the builds with no ldiskfs support. |
| Comment by Christopher Morrone [ 02/Oct/12 ] |
|
You need to get me an explanation of why we can't do this now, and exactly when it will be landed. |
| Comment by Alex Zhuravlev [ 02/Oct/12 ] |
|
Chris, if you'd prefer to land the minimal patch now, I'm fine with patchset #2 (+ ldiskfs enabled by default). |
| Comment by Christopher Morrone [ 02/Oct/12 ] |
|
Patchset 2 + ldiskfs enabled would be great, yes. |
| Comment by Alex Zhuravlev [ 02/Oct/12 ] |
|
I just uploaded that. |
| Comment by Prakash Surya (Inactive) [ 02/Oct/12 ] |
|
Alex, James, please see: http://review.whamcloud.com/4159. |
| Comment by Alex Zhuravlev [ 02/Oct/12 ] |
|
sure, thanks. |
| Comment by Ian Colle (Inactive) [ 08/Oct/12 ] |
|
Both patches 4159 and 4148 landed to master. |