|
Sorry, but coming here from the patch to find out the reason behind the patch, I don't find anything of use. Even if the change were trivial (which in this case it is not, and would have potentially been a serious problem in the network protocol) the patch and bug deserve a clear explanation of what is being fixed, and why it is trivial.
I think that you might have missed the extra zero at the end of the OBD_CONNECT_LIGHTWEIGHT definition (0x1000000000000ULL), and thought it conflicted with OBD_CONNECT_GRANT_PARAM, which is 0x100000000000ULL? Having that kind of explanation in the bug and/or the commit comment would make your reasoning clear.
|
|
Sorry this got on your radar, I will take more care in the future. I was reviewing another patch in this same code area and noticed that the params had skipped order yet were still in the same logical block and that logic was being extended. A little while later I had seen that this also appeared in another wiretest.c and was going to abandon the change to take a bit better look at the situation. I see that it would have caused quite a problem.
It was per-mature for me to submit a patch and I knew it not too long after pushing it via git. I should have invested a bit more time to carefully review the situation before the initial submission.
|