[LU-2158] remove lvfs and fsfilt code Created: 15/Jul/11  Updated: 25/Apr/14  Resolved: 25/Oct/13

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.4.0, Lustre 2.5.0
Fix Version/s: Lustre 2.6.0

Type: Improvement Priority: Minor
Reporter: Andreas Dilger Assignee: Keith Mannthey (Inactive)
Resolution: Fixed Votes: 0
Labels: patch

Issue Links:
Related
is related to LU-2059 mgc to backup configuration on osd-ba... Resolved
is related to LU-4951 DKMS RPM no longer works due to refer... Resolved
is related to LU-3232 fsfilt_ldiskfs.ko should be in osd-ld... Resolved
is related to LU-3961 lustre/lvfs/fsfilt-ldiskfs.c: No such... Closed
Story Points: 3
Severity: 3
Rank (Obsolete): 2626

 Description   

With the fixes to MGS, MDS, and OFD, there should no longer be a need to keep the fsfilt and lvfs infrastructure. Any use of that code should be considered a bug, since it means Lustre is not using the OSD API properly. Any remaining use of fsfilt_ldiskfs can be moved directly into the osd-ldiskfs module.

 Comments   
Comment by Prakash Surya (Inactive) [ 19/Oct/11 ]

Patches proposed:

http://review.whamcloud.com/1546
http://review.whamcloud.com/1547
http://review.whamcloud.com/1548
http://review.whamcloud.com/1549
http://review.whamcloud.com/1550
http://review.whamcloud.com/1551
http://review.whamcloud.com/1552

Plus:
http://review.whamcloud.com/1564
http://review.whamcloud.com/1565

Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » x86_64,client,el5,inkernel #340
ORI-257 fsfilt: Remove bits from fsfilt_ext3.c (Revision 9e0cd86ca1fe542eb73d934ca75e34d4c332fd80)
ORI-257 fsfilt: Remove cruft from lustre_fsfilt.h (Revision 63558858e1e2a95740669c156c5964e8f7d135d7)
ORI-257 lvfs: Remove ll_fid2str from lvfs.h (Revision 2436265b508bc5d9dcb91b69bdbe44ae56c681ce)
ORI-257 lvfs: Remove functions from lvfs_linux.c (Revision ed1a05a14e0df49274d31efce2a4acb84fe6af98)
ORI-257 lvfs: Remove lvfs_common.c (Revision 388c8a109fa03cec0f8570e563c74413f3828ef3)
ORI-257 lvfs: Remove cruft from lvfs directory (Revision c180910fb0e371139740587c2fa4a86c2373198c)
ORI-257 lvfs: Remove ll_sleep from linux/lvfs.h (Revision 6f160387850f20514a1b64c11c3ec6f40c777704)
ORI-257 lvfs: Remove cruft from lvfs_linux.h (Revision 33a69a03b2e2e7337a3bfbc09a704b26a540c7d8)

Result = SUCCESS
Mikhail Pershin : 9e0cd86ca1fe542eb73d934ca75e34d4c332fd80
Files :

  • lustre/lvfs/fsfilt_ext3.c

Mikhail Pershin : 63558858e1e2a95740669c156c5964e8f7d135d7
Files :

  • lustre/lvfs/lvfs_linux.c
  • lustre/include/linux/lustre_fsfilt.h

Mikhail Pershin : 2436265b508bc5d9dcb91b69bdbe44ae56c681ce
Files :

  • lustre/include/lvfs.h

Mikhail Pershin : ed1a05a14e0df49274d31efce2a4acb84fe6af98
Files :

  • lustre/lvfs/lvfs_linux.c
  • lustre/include/linux/lvfs.h

Mikhail Pershin : 388c8a109fa03cec0f8570e563c74413f3828ef3
Files :

  • lustre/lvfs/lvfs_common.c
  • lustre/include/obd_class.h
  • lustre/lvfs/Makefile.in
  • lustre/include/lvfs.h

Mikhail Pershin : c180910fb0e371139740587c2fa4a86c2373198c
Files :

  • lustre/lvfs/lvfs_userfs.c
  • lustre/lvfs/lvfs_linux.c
  • lustre/lvfs/lvfs_darwin.c
  • lustre/lvfs/lvfs_internal.h
  • lustre/lvfs/Info.plist
  • lustre/lvfs/Makefile.in
  • lustre/lvfs/quotafmt_test.c
  • lustre/lvfs/lustre_quota_fmt.c
  • lustre/lvfs/lustre_quota_fmt.h
  • lustre/lvfs/fsfilt_ext3.c
  • lustre/lvfs/autoMakefile.am

Mikhail Pershin : 6f160387850f20514a1b64c11c3ec6f40c777704
Files :

  • lustre/include/linux/lvfs.h

Mikhail Pershin : 33a69a03b2e2e7337a3bfbc09a704b26a540c7d8
Files :

  • lustre/include/linux/lvfs_linux.h
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » i686,client,el6,inkernel #340
ORI-257 fsfilt: Remove bits from fsfilt_ext3.c (Revision 9e0cd86ca1fe542eb73d934ca75e34d4c332fd80)
ORI-257 fsfilt: Remove cruft from lustre_fsfilt.h (Revision 63558858e1e2a95740669c156c5964e8f7d135d7)
ORI-257 lvfs: Remove ll_fid2str from lvfs.h (Revision 2436265b508bc5d9dcb91b69bdbe44ae56c681ce)
ORI-257 lvfs: Remove functions from lvfs_linux.c (Revision ed1a05a14e0df49274d31efce2a4acb84fe6af98)
ORI-257 lvfs: Remove lvfs_common.c (Revision 388c8a109fa03cec0f8570e563c74413f3828ef3)
ORI-257 lvfs: Remove cruft from lvfs directory (Revision c180910fb0e371139740587c2fa4a86c2373198c)
ORI-257 lvfs: Remove ll_sleep from linux/lvfs.h (Revision 6f160387850f20514a1b64c11c3ec6f40c777704)
ORI-257 lvfs: Remove cruft from lvfs_linux.h (Revision 33a69a03b2e2e7337a3bfbc09a704b26a540c7d8)

Result = SUCCESS
Mikhail Pershin : 9e0cd86ca1fe542eb73d934ca75e34d4c332fd80
Files :

  • lustre/lvfs/fsfilt_ext3.c

Mikhail Pershin : 63558858e1e2a95740669c156c5964e8f7d135d7
Files :

  • lustre/include/linux/lustre_fsfilt.h
  • lustre/lvfs/lvfs_linux.c

Mikhail Pershin : 2436265b508bc5d9dcb91b69bdbe44ae56c681ce
Files :

  • lustre/include/lvfs.h

Mikhail Pershin : ed1a05a14e0df49274d31efce2a4acb84fe6af98
Files :

  • lustre/lvfs/lvfs_linux.c
  • lustre/include/linux/lvfs.h

Mikhail Pershin : 388c8a109fa03cec0f8570e563c74413f3828ef3
Files :

  • lustre/include/lvfs.h
  • lustre/lvfs/Makefile.in
  • lustre/lvfs/lvfs_common.c
  • lustre/include/obd_class.h

Mikhail Pershin : c180910fb0e371139740587c2fa4a86c2373198c
Files :

  • lustre/lvfs/quotafmt_test.c
  • lustre/lvfs/lvfs_internal.h
  • lustre/lvfs/lvfs_linux.c
  • lustre/lvfs/lustre_quota_fmt.h
  • lustre/lvfs/lvfs_darwin.c
  • lustre/lvfs/Info.plist
  • lustre/lvfs/autoMakefile.am
  • lustre/lvfs/lvfs_userfs.c
  • lustre/lvfs/lustre_quota_fmt.c
  • lustre/lvfs/Makefile.in
  • lustre/lvfs/fsfilt_ext3.c

Mikhail Pershin : 6f160387850f20514a1b64c11c3ec6f40c777704
Files :

  • lustre/include/linux/lvfs.h

Mikhail Pershin : 33a69a03b2e2e7337a3bfbc09a704b26a540c7d8
Files :

  • lustre/include/linux/lvfs_linux.h
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » i686,server,el5,inkernel #340
ORI-257 fsfilt: Remove bits from fsfilt_ext3.c (Revision 9e0cd86ca1fe542eb73d934ca75e34d4c332fd80)
ORI-257 fsfilt: Remove cruft from lustre_fsfilt.h (Revision 63558858e1e2a95740669c156c5964e8f7d135d7)
ORI-257 lvfs: Remove ll_fid2str from lvfs.h (Revision 2436265b508bc5d9dcb91b69bdbe44ae56c681ce)
ORI-257 lvfs: Remove functions from lvfs_linux.c (Revision ed1a05a14e0df49274d31efce2a4acb84fe6af98)
ORI-257 lvfs: Remove lvfs_common.c (Revision 388c8a109fa03cec0f8570e563c74413f3828ef3)
ORI-257 lvfs: Remove cruft from lvfs directory (Revision c180910fb0e371139740587c2fa4a86c2373198c)
ORI-257 lvfs: Remove ll_sleep from linux/lvfs.h (Revision 6f160387850f20514a1b64c11c3ec6f40c777704)
ORI-257 lvfs: Remove cruft from lvfs_linux.h (Revision 33a69a03b2e2e7337a3bfbc09a704b26a540c7d8)

Result = SUCCESS
Mikhail Pershin : 9e0cd86ca1fe542eb73d934ca75e34d4c332fd80
Files :

  • lustre/lvfs/fsfilt_ext3.c

Mikhail Pershin : 63558858e1e2a95740669c156c5964e8f7d135d7
Files :

  • lustre/include/linux/lustre_fsfilt.h
  • lustre/lvfs/lvfs_linux.c

Mikhail Pershin : 2436265b508bc5d9dcb91b69bdbe44ae56c681ce
Files :

  • lustre/include/lvfs.h

Mikhail Pershin : ed1a05a14e0df49274d31efce2a4acb84fe6af98
Files :

  • lustre/include/linux/lvfs.h
  • lustre/lvfs/lvfs_linux.c

Mikhail Pershin : 388c8a109fa03cec0f8570e563c74413f3828ef3
Files :

  • lustre/include/obd_class.h
  • lustre/lvfs/Makefile.in
  • lustre/lvfs/lvfs_common.c
  • lustre/include/lvfs.h

Mikhail Pershin : c180910fb0e371139740587c2fa4a86c2373198c
Files :

  • lustre/lvfs/lvfs_userfs.c
  • lustre/lvfs/Info.plist
  • lustre/lvfs/lustre_quota_fmt.c
  • lustre/lvfs/fsfilt_ext3.c
  • lustre/lvfs/lustre_quota_fmt.h
  • lustre/lvfs/autoMakefile.am
  • lustre/lvfs/Makefile.in
  • lustre/lvfs/lvfs_linux.c
  • lustre/lvfs/lvfs_internal.h
  • lustre/lvfs/quotafmt_test.c
  • lustre/lvfs/lvfs_darwin.c

Mikhail Pershin : 6f160387850f20514a1b64c11c3ec6f40c777704
Files :

  • lustre/include/linux/lvfs.h

Mikhail Pershin : 33a69a03b2e2e7337a3bfbc09a704b26a540c7d8
Files :

  • lustre/include/linux/lvfs_linux.h
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » x86_64,server,el6,inkernel #340
ORI-257 fsfilt: Remove bits from fsfilt_ext3.c (Revision 9e0cd86ca1fe542eb73d934ca75e34d4c332fd80)
ORI-257 fsfilt: Remove cruft from lustre_fsfilt.h (Revision 63558858e1e2a95740669c156c5964e8f7d135d7)
ORI-257 lvfs: Remove ll_fid2str from lvfs.h (Revision 2436265b508bc5d9dcb91b69bdbe44ae56c681ce)
ORI-257 lvfs: Remove functions from lvfs_linux.c (Revision ed1a05a14e0df49274d31efce2a4acb84fe6af98)
ORI-257 lvfs: Remove lvfs_common.c (Revision 388c8a109fa03cec0f8570e563c74413f3828ef3)
ORI-257 lvfs: Remove cruft from lvfs directory (Revision c180910fb0e371139740587c2fa4a86c2373198c)
ORI-257 lvfs: Remove ll_sleep from linux/lvfs.h (Revision 6f160387850f20514a1b64c11c3ec6f40c777704)
ORI-257 lvfs: Remove cruft from lvfs_linux.h (Revision 33a69a03b2e2e7337a3bfbc09a704b26a540c7d8)

Result = SUCCESS
Mikhail Pershin : 9e0cd86ca1fe542eb73d934ca75e34d4c332fd80
Files :

  • lustre/lvfs/fsfilt_ext3.c

Mikhail Pershin : 63558858e1e2a95740669c156c5964e8f7d135d7
Files :

  • lustre/include/linux/lustre_fsfilt.h
  • lustre/lvfs/lvfs_linux.c

Mikhail Pershin : 2436265b508bc5d9dcb91b69bdbe44ae56c681ce
Files :

  • lustre/include/lvfs.h

Mikhail Pershin : ed1a05a14e0df49274d31efce2a4acb84fe6af98
Files :

  • lustre/include/linux/lvfs.h
  • lustre/lvfs/lvfs_linux.c

Mikhail Pershin : 388c8a109fa03cec0f8570e563c74413f3828ef3
Files :

  • lustre/lvfs/Makefile.in
  • lustre/include/obd_class.h
  • lustre/lvfs/lvfs_common.c
  • lustre/include/lvfs.h

Mikhail Pershin : c180910fb0e371139740587c2fa4a86c2373198c
Files :

  • lustre/lvfs/lvfs_internal.h
  • lustre/lvfs/quotafmt_test.c
  • lustre/lvfs/lvfs_userfs.c
  • lustre/lvfs/autoMakefile.am
  • lustre/lvfs/lvfs_linux.c
  • lustre/lvfs/Makefile.in
  • lustre/lvfs/lvfs_darwin.c
  • lustre/lvfs/Info.plist
  • lustre/lvfs/lustre_quota_fmt.h
  • lustre/lvfs/lustre_quota_fmt.c
  • lustre/lvfs/fsfilt_ext3.c

Mikhail Pershin : 6f160387850f20514a1b64c11c3ec6f40c777704
Files :

  • lustre/include/linux/lvfs.h

Mikhail Pershin : 33a69a03b2e2e7337a3bfbc09a704b26a540c7d8
Files :

  • lustre/include/linux/lvfs_linux.h
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » i686,client,el5,inkernel #340
ORI-257 fsfilt: Remove bits from fsfilt_ext3.c (Revision 9e0cd86ca1fe542eb73d934ca75e34d4c332fd80)
ORI-257 fsfilt: Remove cruft from lustre_fsfilt.h (Revision 63558858e1e2a95740669c156c5964e8f7d135d7)
ORI-257 lvfs: Remove ll_fid2str from lvfs.h (Revision 2436265b508bc5d9dcb91b69bdbe44ae56c681ce)
ORI-257 lvfs: Remove functions from lvfs_linux.c (Revision ed1a05a14e0df49274d31efce2a4acb84fe6af98)
ORI-257 lvfs: Remove lvfs_common.c (Revision 388c8a109fa03cec0f8570e563c74413f3828ef3)
ORI-257 lvfs: Remove cruft from lvfs directory (Revision c180910fb0e371139740587c2fa4a86c2373198c)
ORI-257 lvfs: Remove ll_sleep from linux/lvfs.h (Revision 6f160387850f20514a1b64c11c3ec6f40c777704)
ORI-257 lvfs: Remove cruft from lvfs_linux.h (Revision 33a69a03b2e2e7337a3bfbc09a704b26a540c7d8)

Result = SUCCESS
Mikhail Pershin : 9e0cd86ca1fe542eb73d934ca75e34d4c332fd80
Files :

  • lustre/lvfs/fsfilt_ext3.c

Mikhail Pershin : 63558858e1e2a95740669c156c5964e8f7d135d7
Files :

  • lustre/include/linux/lustre_fsfilt.h
  • lustre/lvfs/lvfs_linux.c

Mikhail Pershin : 2436265b508bc5d9dcb91b69bdbe44ae56c681ce
Files :

  • lustre/include/lvfs.h

Mikhail Pershin : ed1a05a14e0df49274d31efce2a4acb84fe6af98
Files :

  • lustre/lvfs/lvfs_linux.c
  • lustre/include/linux/lvfs.h

Mikhail Pershin : 388c8a109fa03cec0f8570e563c74413f3828ef3
Files :

  • lustre/lvfs/Makefile.in
  • lustre/include/obd_class.h
  • lustre/include/lvfs.h
  • lustre/lvfs/lvfs_common.c

Mikhail Pershin : c180910fb0e371139740587c2fa4a86c2373198c
Files :

  • lustre/lvfs/lvfs_internal.h
  • lustre/lvfs/lustre_quota_fmt.c
  • lustre/lvfs/lvfs_userfs.c
  • lustre/lvfs/quotafmt_test.c
  • lustre/lvfs/Makefile.in
  • lustre/lvfs/lustre_quota_fmt.h
  • lustre/lvfs/lvfs_darwin.c
  • lustre/lvfs/fsfilt_ext3.c
  • lustre/lvfs/autoMakefile.am
  • lustre/lvfs/lvfs_linux.c
  • lustre/lvfs/Info.plist

Mikhail Pershin : 6f160387850f20514a1b64c11c3ec6f40c777704
Files :

  • lustre/include/linux/lvfs.h

Mikhail Pershin : 33a69a03b2e2e7337a3bfbc09a704b26a540c7d8
Files :

  • lustre/include/linux/lvfs_linux.h
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » x86_64,server,el5,inkernel #340
ORI-257 fsfilt: Remove bits from fsfilt_ext3.c (Revision 9e0cd86ca1fe542eb73d934ca75e34d4c332fd80)
ORI-257 fsfilt: Remove cruft from lustre_fsfilt.h (Revision 63558858e1e2a95740669c156c5964e8f7d135d7)
ORI-257 lvfs: Remove ll_fid2str from lvfs.h (Revision 2436265b508bc5d9dcb91b69bdbe44ae56c681ce)
ORI-257 lvfs: Remove functions from lvfs_linux.c (Revision ed1a05a14e0df49274d31efce2a4acb84fe6af98)
ORI-257 lvfs: Remove lvfs_common.c (Revision 388c8a109fa03cec0f8570e563c74413f3828ef3)
ORI-257 lvfs: Remove cruft from lvfs directory (Revision c180910fb0e371139740587c2fa4a86c2373198c)
ORI-257 lvfs: Remove ll_sleep from linux/lvfs.h (Revision 6f160387850f20514a1b64c11c3ec6f40c777704)
ORI-257 lvfs: Remove cruft from lvfs_linux.h (Revision 33a69a03b2e2e7337a3bfbc09a704b26a540c7d8)

Result = SUCCESS
Mikhail Pershin : 9e0cd86ca1fe542eb73d934ca75e34d4c332fd80
Files :

  • lustre/lvfs/fsfilt_ext3.c

Mikhail Pershin : 63558858e1e2a95740669c156c5964e8f7d135d7
Files :

  • lustre/lvfs/lvfs_linux.c
  • lustre/include/linux/lustre_fsfilt.h

Mikhail Pershin : 2436265b508bc5d9dcb91b69bdbe44ae56c681ce
Files :

  • lustre/include/lvfs.h

Mikhail Pershin : ed1a05a14e0df49274d31efce2a4acb84fe6af98
Files :

  • lustre/lvfs/lvfs_linux.c
  • lustre/include/linux/lvfs.h

Mikhail Pershin : 388c8a109fa03cec0f8570e563c74413f3828ef3
Files :

  • lustre/lvfs/lvfs_common.c
  • lustre/lvfs/Makefile.in
  • lustre/include/lvfs.h
  • lustre/include/obd_class.h

Mikhail Pershin : c180910fb0e371139740587c2fa4a86c2373198c
Files :

  • lustre/lvfs/lvfs_linux.c
  • lustre/lvfs/Makefile.in
  • lustre/lvfs/lvfs_internal.h
  • lustre/lvfs/lvfs_darwin.c
  • lustre/lvfs/lustre_quota_fmt.c
  • lustre/lvfs/lustre_quota_fmt.h
  • lustre/lvfs/autoMakefile.am
  • lustre/lvfs/Info.plist
  • lustre/lvfs/quotafmt_test.c
  • lustre/lvfs/lvfs_userfs.c
  • lustre/lvfs/fsfilt_ext3.c

Mikhail Pershin : 6f160387850f20514a1b64c11c3ec6f40c777704
Files :

  • lustre/include/linux/lvfs.h

Mikhail Pershin : 33a69a03b2e2e7337a3bfbc09a704b26a540c7d8
Files :

  • lustre/include/linux/lvfs_linux.h
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » x86_64,client,el6,inkernel #340
ORI-257 fsfilt: Remove bits from fsfilt_ext3.c (Revision 9e0cd86ca1fe542eb73d934ca75e34d4c332fd80)
ORI-257 fsfilt: Remove cruft from lustre_fsfilt.h (Revision 63558858e1e2a95740669c156c5964e8f7d135d7)
ORI-257 lvfs: Remove ll_fid2str from lvfs.h (Revision 2436265b508bc5d9dcb91b69bdbe44ae56c681ce)
ORI-257 lvfs: Remove functions from lvfs_linux.c (Revision ed1a05a14e0df49274d31efce2a4acb84fe6af98)
ORI-257 lvfs: Remove lvfs_common.c (Revision 388c8a109fa03cec0f8570e563c74413f3828ef3)
ORI-257 lvfs: Remove cruft from lvfs directory (Revision c180910fb0e371139740587c2fa4a86c2373198c)
ORI-257 lvfs: Remove ll_sleep from linux/lvfs.h (Revision 6f160387850f20514a1b64c11c3ec6f40c777704)
ORI-257 lvfs: Remove cruft from lvfs_linux.h (Revision 33a69a03b2e2e7337a3bfbc09a704b26a540c7d8)

Result = SUCCESS
Mikhail Pershin : 9e0cd86ca1fe542eb73d934ca75e34d4c332fd80
Files :

  • lustre/lvfs/fsfilt_ext3.c

Mikhail Pershin : 63558858e1e2a95740669c156c5964e8f7d135d7
Files :

  • lustre/include/linux/lustre_fsfilt.h
  • lustre/lvfs/lvfs_linux.c

Mikhail Pershin : 2436265b508bc5d9dcb91b69bdbe44ae56c681ce
Files :

  • lustre/include/lvfs.h

Mikhail Pershin : ed1a05a14e0df49274d31efce2a4acb84fe6af98
Files :

  • lustre/include/linux/lvfs.h
  • lustre/lvfs/lvfs_linux.c

Mikhail Pershin : 388c8a109fa03cec0f8570e563c74413f3828ef3
Files :

  • lustre/include/lvfs.h
  • lustre/lvfs/lvfs_common.c
  • lustre/lvfs/Makefile.in
  • lustre/include/obd_class.h

Mikhail Pershin : c180910fb0e371139740587c2fa4a86c2373198c
Files :

  • lustre/lvfs/lvfs_darwin.c
  • lustre/lvfs/lustre_quota_fmt.h
  • lustre/lvfs/lustre_quota_fmt.c
  • lustre/lvfs/autoMakefile.am
  • lustre/lvfs/lvfs_linux.c
  • lustre/lvfs/lvfs_userfs.c
  • lustre/lvfs/lvfs_internal.h
  • lustre/lvfs/Info.plist
  • lustre/lvfs/fsfilt_ext3.c
  • lustre/lvfs/quotafmt_test.c
  • lustre/lvfs/Makefile.in

Mikhail Pershin : 6f160387850f20514a1b64c11c3ec6f40c777704
Files :

  • lustre/include/linux/lvfs.h

Mikhail Pershin : 33a69a03b2e2e7337a3bfbc09a704b26a540c7d8
Files :

  • lustre/include/linux/lvfs_linux.h
Comment by Christopher Morrone [ 18/Dec/12 ]

Prakash's patches were landed to orion, but never made it to master. I have rebased them and renamed them to "LU-2158" from "ORI-257". They are:

remote: New Changes:
remote: http://review.whamcloud.com/4858
remote: http://review.whamcloud.com/4859
remote: http://review.whamcloud.com/4860
remote: http://review.whamcloud.com/4861
remote: http://review.whamcloud.com/4862
remote: http://review.whamcloud.com/4863
remote: http://review.whamcloud.com/4864

Note that the mgc appears to still be using more fsfilt functions than it did under orion, so when I updated the patches I needed to leave a bit more in than in the original patches.

Comment by Alex Zhuravlev [ 20/Dec/12 ]

great, thanks!

Comment by Mikhail Pershin [ 14/Jan/13 ]

link ticket about making local mgc llog over OSD API

Comment by Alex Zhuravlev [ 17/Jan/13 ]

given Mike's been working on configuration backup patch, I think it makes sense to assign the final cleanup to him.

Comment by James A Simmons [ 01/Feb/13 ]

Several patches have been submitted that chisel at fsfilt but with LU-2059 fsfilt will go away entirely. I like to suggest at this point we focus on removing lvfs_lib.c and lvfs_linux.c.

Comment by Mikhail Pershin [ 12/Feb/13 ]

I am going to remove remaining fsfilt cruft from fsfilt_ext3.c after LU-2059 patch but wonder maybe there are patches for that already?

Comment by James A Simmons [ 12/Feb/13 ]

I have two patches :

http://review.whamcloud.com/#change,5246
http://review.whamcloud.com/#change,5250

but they are aimed at removing non fsfilt type code from lvfs. The goal was to leave only fsfilt which can be removed at a later date. Still missing work on moving proc related code out of lvfs. Outside of that a few patches for LU-1812 touches the fsfilt code but those are place holders until fsfilt goes away.

Comment by Prakash Surya (Inactive) [ 12/Feb/13 ]

And it looks like I only have one patch related to fsfilt outstanding: http://review.whamcloud.com/5195

Comment by Peter Jones [ 19/Feb/13 ]

Keith

Can you please keep an eye on the cleanup patches tracked under this ticket?

Thanks

Peter

Comment by James A Simmons [ 22/Feb/13 ]

With the following patches the fsfilt layer has been removed. The only thing left is some lvfs code which ptlrpc_sec.c depends on as well as osd-ldiskfs. Looks like that code's llog handling needs to be update to the new api.

http://review.whamcloud.com/#change,5049 - LU-2059
http://review.whamcloud.com/#change,5331
http://review.whamcloud.com/#change,5512

Comment by James A Simmons [ 20/May/13 ]

With 2.4 released this looks like it will be completed in 2.5. Peter can you change the Affected version to 2.5

Comment by Peter Jones [ 20/May/13 ]

"Release" may be a little optimistic, but 2.4.0 is certainly code frozen

Comment by Alex Zhuravlev [ 20/May/13 ]

this is actually the code which is not used now...

Comment by James A Simmons [ 20/May/13 ]

The MGS didn't make it to be converted to OSD. So we need fsfilt still.

Comment by Alex Zhuravlev [ 20/May/13 ]

hmm, sorry? we're sort of running MGS with ZFS..

Comment by James A Simmons [ 20/May/13 ]

The MGS backup logs still need the lvfs layer (LU-2059). Also the push_ctx and pop_ctx code in the lvfs layer is used by ptlrpc_sec.c. So the lvfs layer is still needed. As for the fsfilt layer that could be integrated into the osd-ldiskfs layer as I did in http://review.whamcloud.com/#change,5512. Have to make sure its safe for 2.4. Would such a patch be accepted for 2.4.1 is the bigger question?

Comment by Alex Zhuravlev [ 20/May/13 ]

oh, this is MGC.. sorry for confusion

Comment by Christopher Morrone [ 20/May/13 ]

Would such a patch be accepted for 2.4.1 is the bigger question?

While I am quite disappointed that 2.4.0 is going to be released with this unfinished, I would personally argue that the maintenance branch is not the place for this kind of code movement. So I would propose that be added to the 2.5 plan (i.e., change "Fix Version/s" to Lustre 2.5.0).

Comment by James A Simmons [ 21/May/13 ]

With only three months to import the OSD api it is amazing how much did make it in. I have learned if you want a major feature you have to plan on merging over several releases. From what I'm seeing a lot of new work is ready to go as soon as the flood gates for 2.5 are open which is a good thing.

Comment by James A Simmons [ 23/Jul/13 ]

Patches needed to complete this ticket are:

http://review.whamcloud.com/#/c/5331
http://review.whamcloud.com/#/c/5512

Comment by James A Simmons [ 26/Sep/13 ]

Only patch http://review.whamcloud.com/#/c/5512 is left

Comment by Mikhail Pershin [ 26/Sep/13 ]

James, I've just updated patch to resolve new conflicts.

Comment by James A Simmons [ 26/Sep/13 ]

Thank you. Will test.

Comment by James A Simmons [ 25/Oct/13 ]

The last patch has landed. This ticket can be closed.

Comment by Peter Jones [ 25/Oct/13 ]

Landed for 2.6

Generated at Sat Feb 10 01:22:51 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.