[LU-216] Fix fiemap locking issue in 2.6.32 kernels

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.1.0, Lustre 1.8.6
• Fix Version/s: Lustre 2.2.0, Lustre 1.8.6
• Type: Bug
• Priority: Critical
• Reporter: Cory Spitz
• Assignee: Zhenyu Xu
• Resolution: Fixed
• Severity: 3
• Bugzilla ID: 23,780

Description

The patch from Lustre Bugzilla 23780 attachment 31890 was added for RHEL6 support with git commit e550abd05cf7ffddaedbef996be1baaae0912b4a, but a better long term fix is needed.

Johann L. writes in Lustre Bugzilla 23780 comment #28:
> The drawback of this patch is a potential race with fiemap (i did not revert
> the git kernel commit fab3a549e204172236779f502eccb4f9bf0dc87d totally).

and follows up in Lustre Bugzilla 23780 comment #34:
> Please note that this patch is a short term solution.
> Girish, it would be great if you could come up with another patch which takes
> i_data_sem write reference where it is needed in ext4_walk_space().

b1_8 also still requires the fix for SLES 11 SP1.

---

Info required for matching: sanity-benchmark test_fsx fsx

Comments

[Zhenyu Xu]

master branch patch at http://review.whamcloud.com/491

For ext4 based ldiskfs module, ldiskfs_ext_new_extent_cb() get called w/o extent tree protection which opens extent change race window, this patch is to make sure the extent tree is not changed during the race window.

[Zhenyu Xu]

b1_8 only need get rid of ext4-bug23780-remove-i_data_sem-from-walk_space.patch in sles11 series.

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #40
LU-216 Add WALK_SPACE_HAS_DATA_SEM check.

Oleg Drokin : 0fc3c3d84b08a48e2eac04785bd3b3ac1f1ad8eb
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch
• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #40
LU-216 Add WALK_SPACE_HAS_DATA_SEM check.

Oleg Drokin : 0fc3c3d84b08a48e2eac04785bd3b3ac1f1ad8eb
Files :

• lustre/autoconf/lustre-core.m4
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #40
LU-216 Add WALK_SPACE_HAS_DATA_SEM check.

Oleg Drokin : 0fc3c3d84b08a48e2eac04785bd3b3ac1f1ad8eb
Files :

• lustre/autoconf/lustre-core.m4
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #40
LU-216 Add WALK_SPACE_HAS_DATA_SEM check.

Oleg Drokin : 0fc3c3d84b08a48e2eac04785bd3b3ac1f1ad8eb
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch
• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #40
LU-216 Add WALK_SPACE_HAS_DATA_SEM check.

Oleg Drokin : 0fc3c3d84b08a48e2eac04785bd3b3ac1f1ad8eb
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch
• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #40
LU-216 Add WALK_SPACE_HAS_DATA_SEM check.

Oleg Drokin : 0fc3c3d84b08a48e2eac04785bd3b3ac1f1ad8eb
Files :

• lustre/autoconf/lustre-core.m4
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #40
LU-216 Add WALK_SPACE_HAS_DATA_SEM check.

Oleg Drokin : 0fc3c3d84b08a48e2eac04785bd3b3ac1f1ad8eb
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch
• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,ofa #40
LU-216 Add WALK_SPACE_HAS_DATA_SEM check.

Oleg Drokin : 0fc3c3d84b08a48e2eac04785bd3b3ac1f1ad8eb
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch
• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #40
LU-216 Add WALK_SPACE_HAS_DATA_SEM check.

Oleg Drokin : 0fc3c3d84b08a48e2eac04785bd3b3ac1f1ad8eb
Files :

• lustre/autoconf/lustre-core.m4
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #40
LU-216 Add WALK_SPACE_HAS_DATA_SEM check.

Oleg Drokin : 0fc3c3d84b08a48e2eac04785bd3b3ac1f1ad8eb
Files :

• lustre/autoconf/lustre-core.m4
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #40
LU-216 Add WALK_SPACE_HAS_DATA_SEM check.

Oleg Drokin : 0fc3c3d84b08a48e2eac04785bd3b3ac1f1ad8eb
Files :

• lustre/autoconf/lustre-core.m4
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #40
LU-216 Add WALK_SPACE_HAS_DATA_SEM check.

Oleg Drokin : 0fc3c3d84b08a48e2eac04785bd3b3ac1f1ad8eb
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch
• lustre/autoconf/lustre-core.m4

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #40
LU-216 Add WALK_SPACE_HAS_DATA_SEM check.

Oleg Drokin : 0fc3c3d84b08a48e2eac04785bd3b3ac1f1ad8eb
Files :

• lustre/autoconf/lustre-core.m4
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Jian Yu]

Since LU-302 was closed as a duplicate of this ticket, could you please port the patch in http://review.whamcloud.com/#change,491 to b1_8 branch quickly? It's a blocker now. Thanks a lot.

[Zhenyu Xu]

http://review.whamcloud.com/447 is for b1_8 branch.

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,client,el5,inkernel #54
LU-216 Restore WALK_SPACE_HAS_DATA_SEM check.

Johann Lombardi : de95114f8b9f04ef713020b60bfee802316701af
Files :

• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-bug23780-remove-i_data_sem-from-walk_space.patch

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,client,el6,inkernel #54
LU-216 Restore WALK_SPACE_HAS_DATA_SEM check.

Johann Lombardi : de95114f8b9f04ef713020b60bfee802316701af
Files :

• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-bug23780-remove-i_data_sem-from-walk_space.patch
• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,client,ubuntu1004,inkernel #54
LU-216 Restore WALK_SPACE_HAS_DATA_SEM check.

Johann Lombardi : de95114f8b9f04ef713020b60bfee802316701af
Files :

• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• ldiskfs/kernel_patches/patches/ext4-bug23780-remove-i_data_sem-from-walk_space.patch

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,client,el5,ofa #54
LU-216 Restore WALK_SPACE_HAS_DATA_SEM check.

Johann Lombardi : de95114f8b9f04ef713020b60bfee802316701af
Files :

• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• ldiskfs/kernel_patches/patches/ext4-bug23780-remove-i_data_sem-from-walk_space.patch
• lustre/lvfs/fsfilt_ext3.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,server,el5,ofa #54
LU-216 Restore WALK_SPACE_HAS_DATA_SEM check.

Johann Lombardi : de95114f8b9f04ef713020b60bfee802316701af
Files :

• ldiskfs/kernel_patches/patches/ext4-bug23780-remove-i_data_sem-from-walk_space.patch
• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• lustre/lvfs/fsfilt_ext3.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,client,el5,ofa #54
LU-216 Restore WALK_SPACE_HAS_DATA_SEM check.

Johann Lombardi : de95114f8b9f04ef713020b60bfee802316701af
Files :

• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-bug23780-remove-i_data_sem-from-walk_space.patch
• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,client,el6,inkernel #54
LU-216 Restore WALK_SPACE_HAS_DATA_SEM check.

Johann Lombardi : de95114f8b9f04ef713020b60bfee802316701af
Files :

• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-bug23780-remove-i_data_sem-from-walk_space.patch

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,client,el5,inkernel #54
LU-216 Restore WALK_SPACE_HAS_DATA_SEM check.

Johann Lombardi : de95114f8b9f04ef713020b60bfee802316701af
Files :

• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-bug23780-remove-i_data_sem-from-walk_space.patch

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,server,el5,inkernel #54
LU-216 Restore WALK_SPACE_HAS_DATA_SEM check.

Johann Lombardi : de95114f8b9f04ef713020b60bfee802316701af
Files :

• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-bug23780-remove-i_data_sem-from-walk_space.patch
• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,server,el5,ofa #54
LU-216 Restore WALK_SPACE_HAS_DATA_SEM check.

Johann Lombardi : de95114f8b9f04ef713020b60bfee802316701af
Files :

• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-bug23780-remove-i_data_sem-from-walk_space.patch

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,server,el5,inkernel #54
LU-216 Restore WALK_SPACE_HAS_DATA_SEM check.

Johann Lombardi : de95114f8b9f04ef713020b60bfee802316701af
Files :

• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• ldiskfs/kernel_patches/patches/ext4-bug23780-remove-i_data_sem-from-walk_space.patch
• lustre/lvfs/fsfilt_ext3.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,client,el5,ofa #57
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Johann Lombardi : 4c2ea168bb65cb0abe1182e319e650ea3a58da10
Files :

• ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel5-ext4.series
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• ldiskfs/kernel_patches/patches/ext4-walk-space.patch

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,server,el5,ofa #57
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Johann Lombardi : 4c2ea168bb65cb0abe1182e319e650ea3a58da10
Files :

• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• ldiskfs/kernel_patches/patches/ext4-walk-space.patch
• ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel5-ext4.series

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,client,el6,inkernel #57
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Johann Lombardi : 4c2ea168bb65cb0abe1182e319e650ea3a58da10
Files :

• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel5-ext4.series
• ldiskfs/kernel_patches/patches/ext4-walk-space.patch
• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,client,el5,inkernel #57
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Johann Lombardi : 4c2ea168bb65cb0abe1182e319e650ea3a58da10
Files :

• ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel5-ext4.series
• ldiskfs/kernel_patches/patches/ext4-walk-space.patch
• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• lustre/lvfs/fsfilt_ext3.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,client,ubuntu1004,inkernel #57
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Johann Lombardi : 4c2ea168bb65cb0abe1182e319e650ea3a58da10
Files :

• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel5-ext4.series
• ldiskfs/kernel_patches/patches/ext4-walk-space.patch
• lustre/lvfs/fsfilt_ext3.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,client,el5,ofa #57
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Johann Lombardi : 4c2ea168bb65cb0abe1182e319e650ea3a58da10
Files :

• ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel5-ext4.series
• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• ldiskfs/kernel_patches/patches/ext4-walk-space.patch
• lustre/lvfs/fsfilt_ext3.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,client,el5,inkernel #57
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Johann Lombardi : 4c2ea168bb65cb0abe1182e319e650ea3a58da10
Files :

• ldiskfs/kernel_patches/patches/ext4-walk-space.patch
• ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel5-ext4.series
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,client,el6,inkernel #57
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Johann Lombardi : 4c2ea168bb65cb0abe1182e319e650ea3a58da10
Files :

• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• ldiskfs/kernel_patches/patches/ext4-walk-space.patch
• ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel5-ext4.series

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,server,el5,inkernel #57
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Johann Lombardi : 4c2ea168bb65cb0abe1182e319e650ea3a58da10
Files :

• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-walk-space.patch
• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel5-ext4.series

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,server,el5,ofa #57
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Johann Lombardi : 4c2ea168bb65cb0abe1182e319e650ea3a58da10
Files :

• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-walk-space.patch
• ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel5-ext4.series

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,server,el5,inkernel #57
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Johann Lombardi : 4c2ea168bb65cb0abe1182e319e650ea3a58da10
Files :

• ldiskfs/kernel_patches/series/ldiskfs-2.6-rhel5-ext4.series
• ldiskfs/kernel_patches/series/ldiskfs-2.6-sles11.series
• ldiskfs/kernel_patches/patches/ext4-walk-space.patch
• lustre/lvfs/fsfilt_ext3.c

[Peter Jones]

Patch for master being worked as http://review.whamcloud.com/#change,491

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch
• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,ofa #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch
• lustre/lvfs/fsfilt_ext3.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #146
LU-216 Protect extent tree during fsfilt_ldiskfs_ext_walk_space()

Oleg Drokin : dea0c1f27c0eb53d4738a70241ff2bcc47201862
Files :

• ldiskfs/kernel_patches/patches/ext4-misc-sles11.patch
• lustre/lvfs/fsfilt_ext3.c
• ldiskfs/kernel_patches/patches/ext4-misc-rhel6.patch
• ldiskfs/kernel_patches/patches/ext4-misc-rhel5.patch

[Alex Zhuravlev]

I tend to think ldiskfs_ext_next_allocated_block() should be called under i_data_sem together with ldiskfs_ext_find_extent(), otherwise ldiskfs_ext_next_allocated_block() is working on data being modified

[Andrew Perepechko]

Zhenyu Xu, why isn't a hypothetical allocation race in ext3_ext_new_extent_cb() addressed by your patch avoided by means of i_mutex which is taken whenever Lustre calls fsfilt_map_inode_pages(create=1)?

Thanks.

[Zhenyu Xu]

Panda,

I don't quite get you, i_mutex is always hold during the map block process, it is i_data_sem that be used to protect extent block usage. I don't know what "allocation race" you are referring to, would you mind elaborating it?

[Andrew Perepechko]

Zhenyu Xu, I was referring to your patch.

> static int ext3_ext_new_extent_cb()
>...
> if (bp->create == 0)

{ >... > return EXT_CONTINUE; > }

>
> down_write((&EXT4_I(inode)->i_data_sem));
>
> /* validate extent, make sure the extent tree does not changed */
> tmppath = ext4_ext_find_extent(inode, cex->ec_block, NULL);
> if (IS_ERR(tmppath))

{ >... > }
> tmpex = tmppath[depth].p_ext;
> if (tmpex != ex) {>...> }

This patch seems to be expecting that the extent map may have changed during write (which I called allocation race earlier) . However, obdfilter takes i_mutex on writes and truncates and serializes extent map updates with it.

Which case/race is expected to be handled with your code that I quoted above?

Thanks.

[Zhenyu Xu]

Panda, I think you are right, I also couldn't find where the extent tree got changed w/o i_mutex hold, but the in the 1st place, in walk_space, ext4_ext_find_extent is called with i_data_sem protection, then there should exist case where extent got change w/o i_mutex protection, so the issue should be what Bzzz mentioned, we'd protect extent access, i.e. put ldiskfs_ext_next_allocated_block() under i_data_sem lock hold.