[LU-2161] Remove last traces of obdfilter

• Status: Open
• Project: Lustre
• Type: Improvement
• Priority: Minor
• Reporter: Brian Behlendorf
• Assignee: Alex Zhuravlev
• Resolution: Unresolved
• Labels: llnl, server

Sub-Tasks

Key	Summary	Type	Status	Assignee
LU-2096	name ofd device type "ofd" instead of...	Technical task	Open	Alex Zhuravlev

• Key: Summary
• Summary: Type
• Type: Status
• Status: Assignee
• Severity: 3
• Epic: server

Description

I've been meaning to file this for a while, but we really need to get rid of the last vestiges of obdfilter. In particular, the ofd module is still named obdfilter, and related proc infrastructure is still under obdfilter. I presume this was left to accommodate the t-f but its certainly confusing and needs to go.

lustre/ofd/Makefile.in

MODULES := obdfilter

obdfilter-objs := ofd_dev.o ofd_io.o ofd_obd.o ofd_objects.o
obdfilter-objs += lproc_ofd.o ofd_lvb.o ofd_capa.o
obdfilter-objs += ofd_grant.o ofd_recovery.o ofd_fs.o ofd_fmd.o

@INCLUDE_RULES@

Issue Links

• is related to: LU-2096 name ofd device type "ofd" instead of...

Comments

[Andreas Dilger]

Should also clean up the test scripts, /proc filenames, man pages, etc. that reference obdfilter instead of ofd.

[James A Simmons]

This can be linked to LU-2096 since a patch exist that changes the obdfilter proc structure. I think this is a good first step to finish this off. Now in obd.h I see:

#define LUSTRE_OSS_NAME "ost" /* FIXME change name to oss */
#define LUSTRE_OST_NAME "obdfilter" /* FIXME change name to ost */

So in that patch I created real proc directories "ost" and "oss" and created the following symlinks.

lrwxrwxrwx 1 root root 3 Jun 13 14:21 obdfilter -> ost
lrwxrwxrwx 1 root root 3 Jun 13 14:21 ofd -> ost

I also attempted to make oss/OSS look like mds/MDS. Appears in my latest patch the symlink for OSS to ost/ is missing.

[James A Simmons]

Latest patch for LU-2096 clears up the obd device type from obdfilter to ost as well as the proc handling. What is not changed in that patch is the log record recorded on attach. Currently it is recored as "obdfilter" instead of LUSTRE_OST_NAME. Changing that will break downgrades since the OST will not mount. Must ponder a way to support both.