Tracking bug for static code analysis fixes.
(LU-2753)
|
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.4.0, Lustre 2.1.3 |
| Fix Version/s: | Lustre 2.5.0 |
| Type: | Technical task | Priority: | Major |
| Reporter: | Sebastien Buisson (Inactive) | Assignee: | Emoly Liu |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | build, coverity, patch | ||
| Rank (Obsolete): | 5275 |
| Description |
|
Thanks to the Coverity tool, we found some Null pointer dereferences in the Lustre code. I will propose a patch to address the issues. |
| Comments |
| Comment by Sebastien Buisson (Inactive) [ 22/Oct/12 ] |
|
The patch is available here: http://review.whamcloud.com/4369 It implements a defensive approach in some parts of the code, adding many LASSERT() calls. Thanks, |
| Comment by Peter Jones [ 22/Oct/12 ] |
|
Thanks for the patch Sebastien. Emoly Could you please help by reviewing Sebastien's suggested patch? Thanks Peter |
| Comment by Emoly Liu [ 29/Oct/12 ] |
|
Sorry for my late reply. I am still relative new for jira. Emoly |
| Comment by Emoly Liu [ 05/Nov/12 ] |
|
The patch has been reviewed. Since the new assetion in mdt_open.c caused recovery-small.sh test_23 and replay-single.sh test_14 failure, the patch needs to be revised further. |
| Comment by Sebastien Buisson (Inactive) [ 30/Nov/12 ] |
|
The big patch proposed initially has been split into four smaller ones: |
| Comment by Emoly Liu [ 29/Jan/13 ] |
|
Oleg, As Keith mentioned, these patches are a great many LASSERT adds, something like Thanks, |
| Comment by Sebastien Buisson (Inactive) [ 21/May/13 ] |
|
Hi, After reviews, I removed unnecessary assertions from the patches. As the resulting patches are a lot smaller, I reintegrated all the modifications into a single patch, pushed here: The other patches are abandoned. Sebastien. |
| Comment by Peter Jones [ 06/Sep/13 ] |
|
Landed for 2.5 |
[LU-2217]