[LU-225] --with-ldiskfs-inkernel checks wrong file

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.0.0, Lustre 2.1.0
• Fix Version/s: Lustre 2.1.0
• Type: Bug
• Priority: Minor
• Reporter: Ned Bass
• Assignee: Lai Siyao
• Resolution: Fixed
• Severity: 3

Description

Commit fd0bd149e66cbc06a17c372e159f9bfba024cc97 changed which file is checked
to verify a correct ldiskfs installation when the --with-ldiskfs-inkernel
configure option is used:

diff --git a/build/autoconf/lustre-build.m4 b/build/autoconf/lustre-build.m4
index c70afbf..0d9d029 100644
--- a/build/autoconf/lustre-build.m4
+++ b/build/autoconf/lustre-build.m4
...
@@ -221,13 +301,13 @@ case x$with_ldiskfs in
                ;;
        xinkernel)
                AC_MSG_RESULT([inkernel])
-               LB_CHECK_FILE([$LINUX/include/linux/ldiskfs_fs.h],[],[
-                       AC_MSG_ERROR([ldiskfs was not found in $LINUX/include/linux/ldiskfs_fs.h])
+               LB_CHECK_FILE([$LINUX/fs/ldiskfs/inode.c],[],[
+                       AC_MSG_ERROR([ldiskfs was not found in $LINUX/fs/ldiskfs/inode.c])
                ])
                ;;
        *)
                AC_MSG_RESULT([$with_ldiskfs])
-               LB_CHECK_FILE([$with_ldiskfs/ldiskfs/linux/ldiskfs_fs.h],[],[
+               LB_CHECK_FILE([$with_ldiskfs/ldiskfs/inode.c],[],[
                        AC_MSG_ERROR([A complete (built) external ldiskfs was not found.])
                ])
                LDISKFS_DIR=$with_ldiskfs

It looks like the person fixing the *) case assumed the same fix applied to xinkernel).
However, this is wrong because the purpose of --with-ldiskfs-inkernel is to allow us to
build lustre without having full kernel sources available, so inode.c won't exist. I'll
push a fix to gerrit.

Comments

[Ned Bass]

See http://review.whamcloud.com/446

[Peter Jones]

Lai

Could you please look into this one

Thanks

Peter

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #114
LU-225 --with-ldiskfs-inkernel checks wrong file

Oleg Drokin : 7f29ac1fe12ec492e753187535c4d1f1b41c3d82
Files :

• build/autoconf/lustre-build.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #114
LU-225 --with-ldiskfs-inkernel checks wrong file

Oleg Drokin : 7f29ac1fe12ec492e753187535c4d1f1b41c3d82
Files :

• build/autoconf/lustre-build.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #114
LU-225 --with-ldiskfs-inkernel checks wrong file

Oleg Drokin : 7f29ac1fe12ec492e753187535c4d1f1b41c3d82
Files :

• build/autoconf/lustre-build.m4

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #114
LU-225 --with-ldiskfs-inkernel checks wrong file

Oleg Drokin : 7f29ac1fe12ec492e753187535c4d1f1b41c3d82
Files :

• build/autoconf/lustre-build.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #114
LU-225 --with-ldiskfs-inkernel checks wrong file

Oleg Drokin : 7f29ac1fe12ec492e753187535c4d1f1b41c3d82
Files :

• build/autoconf/lustre-build.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #114
LU-225 --with-ldiskfs-inkernel checks wrong file

Oleg Drokin : 7f29ac1fe12ec492e753187535c4d1f1b41c3d82
Files :

• build/autoconf/lustre-build.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #114
LU-225 --with-ldiskfs-inkernel checks wrong file

Oleg Drokin : 7f29ac1fe12ec492e753187535c4d1f1b41c3d82
Files :

• build/autoconf/lustre-build.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,ofa #114
LU-225 --with-ldiskfs-inkernel checks wrong file

Oleg Drokin : 7f29ac1fe12ec492e753187535c4d1f1b41c3d82
Files :

• build/autoconf/lustre-build.m4

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #114
LU-225 --with-ldiskfs-inkernel checks wrong file

Oleg Drokin : 7f29ac1fe12ec492e753187535c4d1f1b41c3d82
Files :

• build/autoconf/lustre-build.m4

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #114
LU-225 --with-ldiskfs-inkernel checks wrong file

Oleg Drokin : 7f29ac1fe12ec492e753187535c4d1f1b41c3d82
Files :

• build/autoconf/lustre-build.m4

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #114
LU-225 --with-ldiskfs-inkernel checks wrong file

Oleg Drokin : 7f29ac1fe12ec492e753187535c4d1f1b41c3d82
Files :

• build/autoconf/lustre-build.m4

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #114
LU-225 --with-ldiskfs-inkernel checks wrong file

Oleg Drokin : 7f29ac1fe12ec492e753187535c4d1f1b41c3d82
Files :

• build/autoconf/lustre-build.m4

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #114
LU-225 --with-ldiskfs-inkernel checks wrong file

Oleg Drokin : 7f29ac1fe12ec492e753187535c4d1f1b41c3d82
Files :

• build/autoconf/lustre-build.m4

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #114
LU-225 --with-ldiskfs-inkernel checks wrong file

Oleg Drokin : 7f29ac1fe12ec492e753187535c4d1f1b41c3d82
Files :

• build/autoconf/lustre-build.m4

[Peter Jones]

Is any further work needed on this issue or can this ticket be marked as RESOLVED?

[Lai Siyao]

No, I think it can be marked RESOLVED.

[Ned Bass]

This can be marked resolved.

Thanks,
Ned