[LU-2259] e2fsprogs: rename liblustreapi.h with lustreapi.h

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.4.0
• Fix Version/s: Lustre 2.5.0
• Type: Bug
• Priority: Minor
• Reporter: Jian Yu
• Assignee: Jian Yu
• Resolution: Fixed
• Severity: 3

Description

After commit f715e4e (LU-1606 api: Rename liblustreapi.h -> lustreapi.h) was landed on master branch, the e2fsprogs build failed as follows:

In file included from /root/lustre-2.3.54/lustre/include/lustre/lustreapi.h:46,
                 from /root/lustre-2.3.54/lustre/include/lustre/liblustreapi.h:40,
                 from ../lib/ext2fs/lfsck.h:14,
                 from lfsck.c:80:
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h: In function 'lustre_lma_swab':
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:345: warning: implicit declaration of function 'cpu_to_le32'
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:346: warning: implicit declaration of function '__swab32s'
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:349: warning: implicit declaration of function '__swab64s'
In file included from /root/lustre-2.3.54/lustre/include/lustre/lustreapi.h:46,
                 from /root/lustre-2.3.54/lustre/include/lustre/liblustreapi.h:40,
                 from ../lib/ext2fs/lfsck.h:14,
                 from lfsck_common.c:29:
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h: In function 'lustre_lma_swab':
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:345: warning: implicit declaration of function 'cpu_to_le32'
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:346: warning: implicit declaration of function '__swab32s'
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:349: warning: implicit declaration of function '__swab64s'
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h: In function 'fid_ostid_unpack':
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:572: warning: implicit declaration of function 'CERROR'
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:572: error: expected ')' before 'LPU64'
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:584: error: expected ')' before 'LPU64'
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:597: error: expected ')' before 'LPU64'
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:603: warning: implicit declaration of function 'unlikely'
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:606: error: expected ')' before 'LPU64'
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h: In function 'fid_ostid_pack':
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:608: error: expected ')' before 'LPX64'
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h: In function 'ostid_seq':
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:658: warning: implicit declaration of function 'CWARN'
/root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:658: error: expected ')' before 'LPU64'

A patch is being created.

Issue Links

• is related to: LU-1606 lustre_idl.h does not compile in user...

Comments

[Jian Yu]

Just renaming liblustreapi.h with lustreapi.h will not fix the above build failures. The main issue is still being resolved in LU-1606.

[Christopher Morrone]

Correct, the header rename was done in a backwards compatible way, if we did it right. It would be nice to update it to the new name, but that will not fix this problem.

[Jian Yu]

Status update:
After LU-1606 is fixed, I'll create a patch for e2fsprogs to rename liblustreapi.h with lustreapi.h.

[Christopher Morrone]

Just be aware that when you do that e2fsprogs will no longer build against any older versions of lustre.

[Jian Yu]

Just be aware that when you do that e2fsprogs will no longer build against any older versions of lustre.

Thanks for the reminder, Chris. After LU-1606 is fixed and e2fsprogs can be built successfully without renaming liblustreapi.h, I'll lower the priority of this ticket.

[Jian Yu]

After the patch for LU-1606 was landed on master branch, building e2fsprogs succeeded on Jenkins:

http://build.whamcloud.com/job/e2fsprogs-reviews/128/arch=x86_64,distro=el6/

Let's lower the priority of this ticket now.

[Chris Gearing (Inactive)]

What is the state of this?

http://build.whamcloud.com/job/e2fsprogs-reviews/128 failed on el5, and didn't get pushed to head.

[Jian Yu]

Hi Chris,

What is the state of this?

http://build.whamcloud.com/job/e2fsprogs-reviews/128 failed on el5, and didn't get pushed to head.

This is TT-955.

[Andreas Dilger]

This problem is fixed in recent e2fsprogs releases. It checks for both lustreapi and liblustreapi in configure.