[LU-2302] Increase lfs_migrate robustness

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.4.0
• Fix Version/s: Lustre 2.4.0
• Type: Improvement
• Priority: Minor
• Reporter: Daniel Kobras (Inactive)
• Assignee: Keith Mannthey (Inactive)
• Resolution: Fixed
• Labels: patch

Description

The lfs_migrate utility suffers from a few robustness issues:

• can temporarily leak information if used by root with a lenient umask;
• fails if called with a non-English locale;
• does not correctly handle newline characters in file/directory names;
• is not compatible between 1.8 and 2.x Lustre versions.

I'll attach patches for all of the above right away. (Corporate firewall blocks access to Gerrit, so I cannot push them directly, unfortunately.)

Comments

[Daniel Kobras (Inactive)]

prevent lfs_migrate data disclosure

[Daniel Kobras (Inactive)]

fix lfs_migrate with non-English locale

[Daniel Kobras (Inactive)]

null-terminated file lists in lfs_migrate

[Daniel Kobras (Inactive)]

make lfs_migrate compatible with 1.8

[Andreas Dilger]

Hi Daniel,
thanks for the patches. Sorry not to get back to you sooner. I saw the patches go through my inbox and thought someone else would take a look at them, but I guess that didn't happen. Someone will be importing them into Gerrit soon.

[Keith Mannthey (Inactive)]

I ported the patches into git. lfs-migrate-nullchar.patch and lfs-migrate-sizeopt.patch had a little patch contextual issues that I worked out. I was not able to use "git am". Did you create the patches from "git format-patch" ?

http://review.whamcloud.com/4697 is: LU-2302 scripts: fix lfs_migrate with non-English locale (locale)
http://review.whamcloud.com/4700 is: LU-2302 scripts: null-terminated file lists in lfs_migrate (nullchar)
http://review.whamcloud.com/4702 is: LU-2302 scripts: make lfs_migrate compatible with 1.8 (sizeopt)
http://review.whamcloud.com/4699 is: LU-2302 scripts: prevent lfs_migrate data disclosure (umask)

[Andreas Dilger]

Keith, please mark an inspection on these patches (even though you submitted them yourself) in Gerrit, since you didn't actually write them.

[Keith Mannthey (Inactive)]

Daniel,
It seems http://review.whamcloud.com/4702 scripts: make lfs_migrate compatible with 1.8 (sizeopt) needs a little work.

If you submit a 2nd version of the patch I will be happy to put it into git for you.

[Keith Mannthey (Inactive)]

While testing http://review.whamcloud.com/4702 an error may have been found in test:

https://maloo.whamcloud.com/test_sets/120d91a0-5b1a-11e2-8985-52540035b04c

== sanity test 56w: check lfs_migrate -c stripe_count works == 18:28:50 (1357784930)
/usr/bin/lfs_migrate -y -c 6 /mnt/lustre/d0.sanity/d56w/file1
/usr/bin/lfs_migrate: line 100: /bin: is a directory
 sanity test_56w: @@@@@@ FAIL: /usr/bin/lfs_migrate -y -c 6 /mnt/lustre/d0.sanity/d56w/file1 failed 

Where /usr/bin/lfs_migrate: line 100 is part of the code changed in the patch.

[Daniel Kobras (Inactive)]

Keith, many thanks for taking care of the patches! I was out of office for several weeks but should be more responsive now. As for the test failure, I've added a note in Gerrit indicating the trivial fix. Could you please adjust the patch accordingly?

[Jodi Levi (Inactive)]

With Change, 4702 landed can this ticket be closed, or is another patch needed?

[Peter Jones]

It looks like this was landed for 2.4