[LU-2319] Remove "Not available for connect" messages Created: 13/Nov/12 Updated: 07/Jun/16 |
|
| Status: | Open |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.4.0 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Prakash Surya (Inactive) | Assignee: | Alex Zhuravlev |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | llnl, shh | ||
| Rank (Obsolete): | 5543 |
| Description |
|
Do these messages provide any real benefit? 2012-11-13 09:54:49 LustreError: 137-5: lstest-MDT0000: Not available for connect from 172.20.4.132@o2ib500 (not set up) 2012-11-13 09:54:49 LustreError: 137-5: lstest-MDT0000: Not available for connect from 172.20.17.141@o2ib500 (not set up) 2012-11-13 09:54:50 LustreError: 137-5: lstest-MDT0000: Not available for connect from 172.20.17.65@o2ib500 (not set up) 2012-11-13 09:54:50 LustreError: Skipped 4 previous similar messages 2012-11-13 09:54:51 LustreError: 137-5: lstest-MDT0000: Not available for connect from 172.20.3.112@o2ib500 (not set up) 2012-11-13 09:54:51 LustreError: Skipped 12 previous similar messages At first glance, it looks like a peer is trying to connect before the target is fully initialized. Why do we need to print this to the console? |
| Comments |
| Comment by Peter Jones [ 13/Nov/12 ] |
|
Alex Can you please triage and assign this one? Thanks Peter |
| Comment by Andreas Dilger [ 13/Nov/12 ] |
|
Unlike some of the other messages, this one is potentially quite important, if the client is trying to connect to a server but the server is not set up or the client is configured incorrectly. |
| Comment by Prakash Surya (Inactive) [ 14/Nov/12 ] |
|
Will these messages really be shown if the target was misconfigured? From what I can tell, it's coming from here: 803 if (target->obd_stopping || !target->obd_set_up) {
804 cfs_spin_unlock(&target->obd_dev_lock);
805
806 deuuidify(str, NULL, &target_start, &target_len);
807 LCONSOLE_ERROR_MSG(0x137, "%.*s: Not available for connect "
808 "from %s (%s)\n", target_len, target_start,
809 libcfs_nid2str(req->rq_peer.nid),
810 (target->obd_stopping ?
811 "stopping" : "not set up"));
812 GOTO(out, rc = -ENODEV);
813 }
So at first glance, I don't see how a configuration error would cause it. And the case where a client is trying to connect to a server by the server is not set up is exactly the case this message for. Why is that important enough to make it to the console? I'd argue, it should handle it silently since that's normal during set up and tear down. |
| Comment by Andreas Dilger [ 15/Nov/12 ] |
|
Sorry, I was thinking of some other message then. |
| Comment by Alex Zhuravlev [ 15/Nov/12 ] |
|
Andreas, would you agree to turn this into CDEBUG() ? |