[LU-239] Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.0.0
• Fix Version/s: Lustre 2.1.0
• Type: Bug
• Priority: Minor
• Reporter: Lai Siyao
• Assignee: Lai Siyao
• Resolution: Fixed

Environment

ISO C99

• Severity: 3
• Bugzilla ID: 23,787
• Epic: C99, ISO

Description

Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint. In particular, there is a small section in lustre/include/lprocfs_status.h that fails to compile with PGI. This involves the use of a GCC extension in lprocfs_status.h for flexible arrays:

161 struct lprocfs_percpu

{ 162 struct lprocfs_counter lp_cntr[0]; 163 }

;

In this particular case, the nature of the extension is that the flexible array is the sole member
of the structure. So, one way to fix this is to make the structure ISO C99 compliant:

161 struct lprocfs_percpu

{ 162 int lp_pad; 163 struct lprocfs_counter lp_cntr[0]; 164 }

;

Comments

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #110
LU-239 Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

Oleg Drokin : 8be13c069909b9ba741885aca963279ebb1cbdd8
Files :

• lustre/include/lprocfs_status.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #110
LU-239 Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

Oleg Drokin : 8be13c069909b9ba741885aca963279ebb1cbdd8
Files :

• lustre/include/lprocfs_status.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #110
LU-239 Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

Oleg Drokin : 8be13c069909b9ba741885aca963279ebb1cbdd8
Files :

• lustre/include/lprocfs_status.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #110
LU-239 Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

Oleg Drokin : 8be13c069909b9ba741885aca963279ebb1cbdd8
Files :

• lustre/include/lprocfs_status.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #110
LU-239 Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

Oleg Drokin : 8be13c069909b9ba741885aca963279ebb1cbdd8
Files :

• lustre/include/lprocfs_status.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #110
LU-239 Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

Oleg Drokin : 8be13c069909b9ba741885aca963279ebb1cbdd8
Files :

• lustre/include/lprocfs_status.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #110
LU-239 Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

Oleg Drokin : 8be13c069909b9ba741885aca963279ebb1cbdd8
Files :

• lustre/include/lprocfs_status.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,ofa #110
LU-239 Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

Oleg Drokin : 8be13c069909b9ba741885aca963279ebb1cbdd8
Files :

• lustre/include/lprocfs_status.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #110
LU-239 Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

Oleg Drokin : 8be13c069909b9ba741885aca963279ebb1cbdd8
Files :

• lustre/include/lprocfs_status.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #110
LU-239 Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

Oleg Drokin : 8be13c069909b9ba741885aca963279ebb1cbdd8
Files :

• lustre/include/lprocfs_status.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #110
LU-239 Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

Oleg Drokin : 8be13c069909b9ba741885aca963279ebb1cbdd8
Files :

• lustre/include/lprocfs_status.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #110
LU-239 Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

Oleg Drokin : 8be13c069909b9ba741885aca963279ebb1cbdd8
Files :

• lustre/include/lprocfs_status.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #110
LU-239 Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

Oleg Drokin : 8be13c069909b9ba741885aca963279ebb1cbdd8
Files :

• lustre/include/lprocfs_status.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #110
LU-239 Lustre Header (include/lprocfs_status.h) is not ISO C99 complaint

Oleg Drokin : 8be13c069909b9ba741885aca963279ebb1cbdd8
Files :

• lustre/include/lprocfs_status.h

[Peter Jones]

Landed for 2.1