[#LU-2394] Possible NULL pointer dereference in cat_cancel

[LU-2394] Possible NULL pointer dereference in cat_cancel_cb Created: 27/Nov/12 Updated: 29/Nov/12 Resolved: 29/Nov/12
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	Lustre 2.4.0
Fix Version/s:	Lustre 2.4.0

Type:

Bug

Priority:

Critical

Reporter:

Prakash Surya (Inactive)

Assignee:

Alex Zhuravlev

Resolution:

Fixed

Votes:

Labels:

topsequoia

Severity:

Rank (Obsolete):

5672

Description

If llog_cat_id2handle fails and returns a positive value, it may free
its 'res' parameter and set it to NULL. Thus, a caller must be cautious
not to cause a NULL pointer dereference on error.

Specifically, the cat_cancel_cb function does not take this precaution, which can manifest itself in a NULL pointer dereference.

See here for the patch to fix cat_cancel_cb: 4676

Comments

Comment by Peter Jones [ 27/Nov/12 ]

Alex could you please comment on this one? Thanks Peter

Comment by Alex Zhuravlev [ 28/Nov/12 ]

the patch is fine. thanks, Prakash.

Comment by Prakash Surya (Inactive) [ 29/Nov/12 ]

Patch landed to master: http://review.whamcloud.com/4676

Generated at Sat Feb 10 01:24:50 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.

[LU-2394] Possible NULL pointer dereference in cat_cancel_cb Created: 27/Nov/12 Updated: 29/Nov/12 Resolved: 29/Nov/12