[LU-2426] newwiretest not run before starting a test Created: 04/Dec/12 Updated: 05/Aug/20 Resolved: 04/Dec/12 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | CEA | Assignee: | Bob Glossman (Inactive) |
| Resolution: | Not a Bug | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 5751 |
| Description |
|
when a patch is pushed for review, make -C utils/newwiretest is not done so we have to commit the wiretest modifications |
| Comments |
| Comment by Peter Jones [ 04/Dec/12 ] |
|
Bob Could you please look into this one? Thanks Peter |
| Comment by Bob Glossman (Inactive) [ 04/Dec/12 ] |
|
This is not a bug. Generation of new wiretest.c files is intended to be a manual operation, not automatic in every build. Unless there is a specific need for fresh wiretest source files the previously committed versions are kept and reused in every build. New files are generated by manually invoking 'make newwiretest' after a build, then the new files are committed with 'git commit'. |
| Comment by Andreas Dilger [ 04/Dec/12 ] |
|
Bob is exactly correct. Changing the network protocol should be an intentional action, which is exactly why we have the wiretest.c programs to verify each build that it has NOT changed. I'm sure we could add more checks to these files, since I don't think they cover enough aspects of the actual protocol usage, but they are at least a reasonable first guard against protocol changes. |
| Comment by jacques-charles lafoucriere [ 05/Dec/12 ] |
|
So when we push a patch we have to push the wiretest.c changes. |