[LU-245] port patch of bug22820 to 2.0 (too many default ACLs break directory access on new directories)

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.0.0
• Fix Version/s: Lustre 2.1.0
• Type: Bug
• Priority: Minor
• Reporter: Zhenyu Xu
• Assignee: Zhenyu Xu
• Resolution: Fixed
• Severity: 3
• Bugzilla ID: 22,820

Description

issue:
Creating directories in a directory with 33 default ACLs on it completely breaks access to these
new directories. It seems that there should be a check when setting default ACLs to not allow more
than 32.

This can be easily reproduced like this:

1) make sure your MDS supports ACLs
2) create a new directory
3) define 33 default ACLs on the new directory
4) create another directory in the new directory
5) try to ls the new directory

[acltest]$ mkdir testdir
[acltest]$ for i in $(seq 1 29) ; setfacl -m d:g:ltest${i}:r testdir ; done
[acltest]$ getfacl --omit-header testdir |grep default |wc -l
33
[acltest]$ mkdir testdir/testdir
[acltest]$ ls -l testdir/
total 0
?---------+ ? ? ? ? ? testdir
[acltest]$

[acltest]$ getfacl --omit-header testdir
user::rwx
group::rwx
mask::rwx
other::r-x
default:user::rwx
default:group::rwx
default:group:ltest1:r--
default:group:ltest2:r--
default:group:ltest3:r--
default:group:ltest4:r--
default:group:ltest5:r--
default:group:ltest6:r--
default:group:ltest7:r--
default:group:ltest8:r--
default:group:ltest9:r--
default:group:ltest10:r--
default:group:ltest11:r--
default:group:ltest12:r--
default:group:ltest13:r--
default:group:ltest14:r--
default:group:ltest15:r--
default:group:ltest16:r--
default:group:ltest17:r--
default:group:ltest18:r--
default:group:ltest19:r--
default:group:ltest20:r--
default:group:ltest21:r--
default:group:ltest22:r--
default:group:ltest23:r--
default:group:ltest24:r--
default:group:ltest25:r--
default:group:ltest26:r--
default:group:ltest27:r--
default:group:ltest28:r--
default:group:ltest29:r--
default:mask::rwx
default:other::r-x

Expected Results:
Error message when setting the default ACL 33 or 33 ACLs on the new directory

Comments

[Zhenyu Xu]

patch tracking at http://review.whamcloud.com/471

[Peter Jones]

Bobijam it would be a good idea to provide at least a description of the original problem in case bz is unavailable

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,ofa #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c

[Zhenyu Xu]

landed on master for 2.1.0

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #155
LU-245 too many default ACLs break directory access on new directories

Oleg Drokin : 45ec57b73eb3426db7b997c88d49e18eb52a8f4f
Files :

• lustre/mdt/mdt_xattr.c