[LU-2469] Test-framework.sh ignores MDSDEV when FSTYPE=zfs

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.4.0
• Fix Version/s: Lustre 2.6.0
• Type: Bug
• Priority: Minor
• Reporter: Cliff White (Inactive)
• Assignee: Nathaniel Clark
• Resolution: Fixed
• Labels: zfs
• Severity: 3

Description

Test-framework.sh ignores MDSDEV here:

mdsdevname() {
    num=$1
    DEVNAME=MDSDEV$num

        local fstype=$(facet_fstype mds$num)

        case $fstype in
                ldiskfs )
                        #if $MDSDEVn isn't defined, default is $MDSDEVBASE + num
                        eval DEVPTR=${!DEVNAME:=${MDSDEVBASE}${num}};;
                zfs )   
                        #dataset name is independent of vdev device names
                        eval DEVPTR=${FSNAME}-mdt${num}/mdt${num};;
                * )
                        error "unknown fstype!";;
        esac

andreas suggests:
eval DEVPTR=${!DEVNAME:=${FSNAME}-mdt${num}/mdt${num}}"
as a fix

Issue Links

• is duplicated by: LU-2787 review-zfs lustre-initialization_1 I...
• is duplicated by: LU-2678 Failure on test suite conf-sanity tes...
• is related to: LU-2734 ZFS testin failure: "no label for lus...

Comments

[Nathaniel Clark]

http://review.whamcloud.com/4854

[Di Wang]

This patch cause following error. Please check

[root@testnode tests]# FSTYPE=zfs sh llmount.sh
Stopping clients: testnode /mnt/lustre (opts
Stopping clients: testnode /mnt/lustre2 (opts
Loading modules from /work/lustre-release/lustre/tests/..
detected 2 online CPUs by sysfs
Force libcfs to create 2 CPU partitions
../libcfs/libcfs/libcfs options: 'cpu_npartitions=2'
debug=vfstrace rpctrace dlmtrace neterror ha config ioctl super
subsystem_debug=all -lnet -lnd -pinger
gss/krb5 is not supported
quota/lquota options: 'hash_lqs_cur_bits=3'
Formatting mgs, mds, osts
Format mds1: /tmp/lustre-mdt1

mkfs.lustre FATAL: Invalid filesystem name /tmp/lustre-mdt1

mkfs.lustre FATAL: unable to prepare backend (22)
mkfs.lustre: exiting with 22 (Invalid argument)

[Andreas Dilger]

Oleg is reverting this patch due to the severe breakage. It needs to be fixed and resubmitted after it passes testing with ZFS enabled (using Test-Parameters.

[Andreas Dilger]

See http://wiki.whamcloud.com/plugins/servlet/content/view/8552564

[Nathaniel Clark]

Reworked patch

http://review.whamcloud.com/5016

[Nathaniel Clark]

Skip failing zfs tests:
http://review.whamcloud.com/5472

[Andreas Dilger]

Patches for this bug are landed, should it be closed?

[Jessica A. Popp (Inactive)]

Nathaniel - Can this be closed?

[Nathaniel Clark]

Should this be cherry-picked for 2.5.1?