[LU-2528] Is the "consider upgrading" console message necessary? Created: 26/Dec/12 Updated: 31/Dec/13 Resolved: 19/Dec/13 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.1.2 |
| Fix Version/s: | Lustre 2.6.0, Lustre 2.5.1 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Prakash Surya (Inactive) | Assignee: | Bob Glossman (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | mn1, shh | ||
| Rank (Obsolete): | 5947 |
| Description |
|
Is this message really necessary: 2012-12-19 16:10:59 Lustre: Server ls1-OST0143_UUID version (2.3.57.0) is much newer than client version. Consider upgrading client (2.1.2) ? I vote for its removal. I feel like I've already opened a ticket on this message, but after a quick search it didn't turn up. |
| Comments |
| Comment by Peter Jones [ 27/Dec/12 ] |
|
Oleg What do you think about this? Peter |
| Comment by Andreas Dilger [ 28/Dec/12 ] |
|
The actual code in question is: if ((ocd->ocd_connect_flags & OBD_CONNECT_VERSION) &&
(ocd->ocd_version > LUSTRE_VERSION_CODE +
LUSTRE_VERSION_OFFSET_WARN ||
ocd->ocd_version < LUSTRE_VERSION_CODE -
LUSTRE_VERSION_OFFSET_WARN)) {
For 2.1 LUSTRE_VERSION_OFFSET_WARN is OBD_OCD_VERSION(0,0,1,32), while on master it is OBD_OCD_VERSION(0,252,0,0), so there will not be any warning messages on 2.4 already. It would be trivial to back-port this larger version margin to 2.1. |
| Comment by Prakash Surya (Inactive) [ 02/Jan/13 ] |
|
There shouldn't be a printed message like this printed for any two compatible versions, IMO. I don't see much value in it. |
| Comment by Andreas Dilger [ 02/Jan/13 ] |
|
It was originally added for the Cray/libcfs clients, which did not have any cross-version interoperability. The Linux client check is more intended to alert administrators if there are clients that are very old before they break due to some incompatible change. In sites like LLNL where the clients are well controlled this is extraneous. In other customer sites where there are a mix of clients this is useful to alert administrators of old clients, and allows us to deprecate support for old versions of Lustre more easily. I'm not dead set on keeping this message, but I think that fixing 2.1 to match master would be enough to avoid the problems reported here. Oleg, any opinions on this? |
| Comment by Prakash Surya (Inactive) [ 02/Jan/13 ] |
|
Oh, OK. Well I can see value in using a message to report deprecated releases. Though, it'd be nice to do that in a less intrusive way. IIRC, this message is printed for each connection made, which can spam the console log when using many OSTs or when many disconnect/reconnects happen in a short period of time. |
| Comment by Andreas Dilger [ 10/Oct/13 ] |
|
I realized we will again have a problem with this for 2.5.n clients connecting to 2.1.(n-1) servers, and vice versa. I've increased the window to be +/- 0.4.50 versions, since we don't plan to allow interoperation between 2.1 and 2.6 releases. It also quiets the warning so that it only prints once. Patch for b2_1: http://review.whamcloud.com/7917 |
| Comment by Andreas Dilger [ 19/Dec/13 ] |
|
patch landed to master for 2.6.0, closing bug. |