[LU-2546] test: sanity FAIL: test_140 Invalid symlink depth Created: 28/Dec/12  Updated: 03/Jan/13  Resolved: 03/Jan/13

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.3.0
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Jay Lan (Inactive) Assignee: Nathaniel Clark
Resolution: Duplicate Votes: 0
Labels: sles11
Environment:

server: 2.1.3-1nasS, centos 6.3, 2.6.32_279.2.1.el6
client: 2.3.0-1nasC, sles11sp2, 3.0.42_0.7.3
1 mds, 2 oss, 2 clients.


Attachments: File sanity.test_140.tgz    
Issue Links:
Duplicate
duplicates LU-2020 sanity 140 should allow 40 consecutiv... Resolved
Severity: 3
Rank (Obsolete): 5969

 Description   

== sanity test 140: Check reasonable stack depth (shouldn't LBUG) ==================================== 17:37:58 (1356658678)
The symlink depth = 40
sanity test_140: @@@@@@ FAIL: Invalid symlink depth

The test_logs are uploaded as 'sanity.test_140.tgz'.
The test was run on service331.



 Comments   
Comment by Peter Jones [ 28/Dec/12 ]

Nathaniel

I think that you have worked in this area recently so could you please comment on this one?

Thanks

Peter

Comment by Bob Glossman (Inactive) [ 31/Dec/12 ]

I think this is due to the 3.6 kernel in sles11 sp2 having the commit b356379a020bb7197603118bb1cbc903963aa198. This restructures the handling of trailing symlinks in pathnames. They are now recognized and handled as iterative, not as nested and recursive. Iterative sequences of symlinks have the much higher limit of 40, not MAX_NESTED_LINKS (8) in vfs code.
Either the test can be changed to accept 40 as a valid loop count, or the test can be changed to create symlink sequences that will be recognized as recursive in even the newest kernel versions of vfs code.

Comment by Bob Glossman (Inactive) [ 31/Dec/12 ]

sorry, got a bit confused about kernel versions. It's 3.0 kernel in sles11 sp2, not 3.6. My point about the commit changing symlink handling is valid anyway. It's there in 3.0 too.

Comment by Jay Lan (Inactive) [ 31/Dec/12 ]

Do you have a link to the commit, Bob? Thanks!

Comment by Bob Glossman (Inactive) [ 01/Jan/13 ]

This is the link I found: http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=commit;h=b356379a020bb7197603118bb1cbc903963aa198

It appears to be one of a series of related commits revising symlink handling in vfs path walk code from ~3/2011

Comment by Nathaniel Clark [ 02/Jan/13 ]

This was fixed in master by bug LU-2020

The following change can be cleanly cherry-picked onto both 2.1 and 2.3
http://review.whamcloud.com/4079

Comment by Jay Lan (Inactive) [ 02/Jan/13 ]

Thanks, Nathaniel. Test_140 passed with this patch.

Generated at Sat Feb 10 01:26:07 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.