Tracking bug for static code analysis fixes.
(LU-2753)
|
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.4.0 |
| Fix Version/s: | Lustre 2.7.0 |
| Type: | Technical task | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | John Hammond |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||||||
| Epic: | RoDC, cleanup | ||||||||||||||||||||
| Rank (Obsolete): | 6248 | ||||||||||||||||||||
| Description |
|
Tracking for minor cleanups suggested by sparse checker. |
| Comments |
| Comment by John Hammond [ 24/Jan/13 ] |
|
http://review.whamcloud.com/5166 make bitfield (un)signedness explicit |
| Comment by John Hammond [ 25/Jan/13 ] |
|
http://review.whamcloud.com/5175 remove User Mode Linux specific code |
| Comment by John Hammond [ 25/Jan/13 ] |
|
http://review.whamcloud.com/5177 remove unused mkdirdeep.c lltrace.h |
| Comment by John Hammond [ 25/Jan/13 ] |
|
http://review.whamcloud.com/5178 static and extern corrections for libcfs |
| Comment by John Hammond [ 28/Jan/13 ] |
|
http://review.whamcloud.com/5190 remove unused recov_thread.c and llog code |
| Comment by John Hammond [ 20/Feb/13 ] |
|
5166: make bitfield (un)signedness explicit landed. |
| Comment by John Hammond [ 04/Mar/13 ] |
|
http://review.whamcloud.com/5580 echo: remove #if 0-ed out regions from echo_client.c |
| Comment by John Hammond [ 04/Mar/13 ] |
|
http://review.whamcloud.com/5581 lov: remove some dead lov code |
| Comment by John Hammond [ 14/Jun/13 ] |
|
http://review.whamcloud.com/6660 lvfs: cleanup lvfs.h and collateral |
| Comment by John Hammond [ 12/Jul/13 ] |
|
http://review.whamcloud.com/6969 cleanup: define sparse annotations for libcfs |
| Comment by Jodi Levi (Inactive) [ 02/Jun/14 ] |
|
Patches have landed to Master. If more work is needed, please reopen a new ticket. |
| Comment by Gerrit Updater [ 25/Nov/14 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/12849 |
| Comment by Gerrit Updater [ 25/Nov/14 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/12850 |
| Comment by Gerrit Updater [ 25/Nov/14 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/12851 |
| Comment by Gerrit Updater [ 01/Dec/14 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/12893 |
| Comment by Gerrit Updater [ 03/Dec/14 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/12922 |
| Comment by Gerrit Updater [ 04/Dec/14 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12113/ |
| Comment by Gerrit Updater [ 04/Dec/14 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12115/ () |
| Comment by Gerrit Updater [ 04/Dec/14 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12117/ |
| Comment by Gerrit Updater [ 04/Dec/14 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12231/ |
| Comment by Gerrit Updater [ 04/Dec/14 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/12932 |
| Comment by Isaac Huang (Inactive) [ 05/Dec/14 ] |
|
Now that the lnet/ulnds code has been removed, the code under lnet/lnet that supports userspace LNDs should be removed as well. To find such code, just: grep __KERNEL__ lnet/lnet/*.[ch] |
| Comment by John Hammond [ 05/Dec/14 ] |
|
Isaac, Yes. I will push a patch eventually to do this. I would like to sort out the headers a bit first. lib-types.h contains some structures and defines that are shared by kernel space and user space, and some that are kernel only. I could move the shared stuff to lnet/types.h, or to some other header, or to a new header. Once it is clear which headers are shared I will unifdef _KERNEL_ all the others along with the appropriate .c files. |
| Comment by Gerrit Updater [ 09/Dec/14 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12849/ |
| Comment by Jodi Levi (Inactive) [ 09/Dec/14 ] |
|
Patch landed to Master. |
| Comment by Amir Shehata (Inactive) [ 17/Dec/14 ] |
|
As part of this change we should ensure that we remove the_lnet.ln_eq_waitni and associated logic, since this is not used at all for the LNet Kernel code. |
| Comment by Isaac Huang (Inactive) [ 18/Dec/14 ] |
|
Also, many Doxygen comments over lnet APIs (those whose names begin with LNet) include stuff that only applies to user space. Those can be removed as well. |
| Comment by Gerrit Updater [ 18/Dec/14 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12851/ |
| Comment by Gerrit Updater [ 18/Dec/14 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12893/ |
| Comment by Gerrit Updater [ 18/Dec/14 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/13121 |
| Comment by Gerrit Updater [ 18/Dec/14 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/13123 |
| Comment by Gerrit Updater [ 26/Dec/14 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12850/ |
| Comment by Gerrit Updater [ 26/Dec/14 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12932/ |
| Comment by Gerrit Updater [ 26/Dec/14 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13123/ |
| Comment by Gerrit Updater [ 29/Dec/14 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/13196 |
| Comment by Gerrit Updater [ 04/Jan/15 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13196/ |
| Comment by Gerrit Updater [ 07/Jan/15 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/13271 |
| Comment by Gerrit Updater [ 10/Jan/15 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13271/ |
| Comment by Gerrit Updater [ 10/Jan/15 ] |
|
James Simmons (uja.ornl@gmail.com) uploaded a new patch: http://review.whamcloud.com/13339 |
| Comment by Gerrit Updater [ 22/Jan/15 ] |
|
Li Xi (pkuelelixi@gmail.com) uploaded a new patch: http://review.whamcloud.com/13495 |
| Comment by Gerrit Updater [ 27/Jan/15 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13495/ |
| Comment by Jodi Levi (Inactive) [ 27/Jan/15 ] |
|
Patches landed to Master. |
| Comment by Gerrit Updater [ 03/Feb/15 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13121/ |
| Comment by Gerrit Updater [ 09/Feb/15 ] |
|
Isaac Huang (he.huang@intel.com) uploaded a new patch: http://review.whamcloud.com/13698 |
| Comment by Gerrit Updater [ 31/Mar/15 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13698/ |
| Comment by Gerrit Updater [ 15/Dec/15 ] |
|
Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: http://review.whamcloud.com/17593 |
[LU-2675]